-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(WAFv2): add patch to revert struct names (#24703)
This PR is reverting the property type names from pattern `FooAction` to `Foo` for `WAFv2` resource. This change was introduced as part of a [CFNSpec merge](affe040#diff-827a2fd012e049c7ccedffa0360c12e7d967a173f36b8150de73ef6adc42ee4cL175-L357) and would be breaking existing customers if they were using previous property names. Duplicating from [PR](#24651) for same issue for V2. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information
1 parent
a2d9439
commit e03d8b8
Showing
2 changed files
with
111 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
102 changes: 102 additions & 0 deletions
102
...fnspec/spec-source/specification/000_cfn/500_WAFv2_RuleGroup_Rename_Properties_patch.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| { | ||
| "patch": { | ||
| "description": "Reverting property type names from FooAction to Foo, which were introduced as part of this PR: https://github.com/aws/aws-cdk/pull/23984", | ||
| "operations": [ | ||
| { | ||
| "op": "remove", | ||
| "path": "/PropertyTypes/AWS::WAFv2::RuleGroup.AllowAction" | ||
| }, | ||
| { | ||
| "op": "add", | ||
| "path": "/PropertyTypes/AWS::WAFv2::RuleGroup.Allow", | ||
| "value": { | ||
| "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-allowaction.html", | ||
| "Properties": { | ||
| "CustomRequestHandling": { | ||
| "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-allowaction.html#cfn-wafv2-rulegroup-allowaction-customrequesthandling", | ||
| "Required": false, | ||
| "Type": "CustomRequestHandling", | ||
| "UpdateType": "Mutable" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "op": "remove", | ||
| "path": "/PropertyTypes/AWS::WAFv2::RuleGroup.BlockAction" | ||
| }, | ||
| { | ||
| "op": "add", | ||
| "path": "/PropertyTypes/AWS::WAFv2::RuleGroup.Block", | ||
| "value": { | ||
| "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-blockaction.html", | ||
| "Properties": { | ||
| "CustomResponse": { | ||
| "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-blockaction.html#cfn-wafv2-rulegroup-blockaction-customresponse", | ||
| "Required": false, | ||
| "Type": "CustomResponse", | ||
| "UpdateType": "Mutable" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "op": "remove", | ||
| "path": "/PropertyTypes/AWS::WAFv2::RuleGroup.CaptchaAction" | ||
| }, | ||
| { | ||
| "op": "add", | ||
| "path": "/PropertyTypes/AWS::WAFv2::RuleGroup.Captcha", | ||
| "value": { | ||
| "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-captchaaction.html", | ||
| "Properties": { | ||
| "CustomRequestHandling": { | ||
| "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-captchaaction.html#cfn-wafv2-rulegroup-captchaaction-customrequesthandling", | ||
| "Required": false, | ||
| "Type": "CustomRequestHandling", | ||
| "UpdateType": "Mutable" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "op": "remove", | ||
| "path": "/PropertyTypes/AWS::WAFv2::RuleGroup.ChallengeAction" | ||
| }, | ||
| { | ||
| "op": "add", | ||
| "path": "/PropertyTypes/AWS::WAFv2::RuleGroup.Challenge", | ||
| "value": { | ||
| "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-challengeaction.html", | ||
| "Properties": { | ||
| "CustomRequestHandling": { | ||
| "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-challengeaction.html#cfn-wafv2-rulegroup-challengeaction-customrequesthandling", | ||
| "Required": false, | ||
| "Type": "CustomRequestHandling", | ||
| "UpdateType": "Mutable" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "op": "remove", | ||
| "path": "/PropertyTypes/AWS::WAFv2::RuleGroup.CountAction" | ||
| }, | ||
| { | ||
| "op": "add", | ||
| "path": "/PropertyTypes/AWS::WAFv2::RuleGroup.Count", | ||
| "value": { | ||
| "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-countaction.html", | ||
| "Properties": { | ||
| "CustomRequestHandling": { | ||
| "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-countaction.html#cfn-wafv2-rulegroup-countaction-customrequesthandling", | ||
| "Required": false, | ||
| "Type": "CustomRequestHandling", | ||
| "UpdateType": "Mutable" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } |