Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin @types/prettier to 2.6.0 #20322

Merged
merged 2 commits into from
May 12, 2022
Merged

chore: pin @types/prettier to 2.6.0 #20322

merged 2 commits into from
May 12, 2022

Conversation

corymhall
Copy link
Contributor

@types/prettier is a transitive dependency of jest. Version 2.6.1
introduced a breaking change by increasing the minimum supported
version of typescript to 4.2. See related issue for more information.

re #20319


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@types/prettier is a transitive dependency of `jest`. Version `2.6.1`
introduced a breaking change by increasing the minimum supported
version of typescript to `4.2`. See related issue for more information.

re #20319
@gitpod-io
Copy link

gitpod-io bot commented May 12, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team May 12, 2022 21:48
@github-actions github-actions bot added the p2 label May 12, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 12, 2022
@corymhall corymhall requested a review from a team May 12, 2022 21:51
@corymhall corymhall closed this May 12, 2022
@corymhall corymhall reopened this May 12, 2022
@mergify
Copy link
Contributor

mergify bot commented May 12, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 270cdc7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 38e62a7 into aws:master May 12, 2022
@mergify
Copy link
Contributor

mergify bot commented May 12, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

corymhall added a commit that referenced this pull request May 12, 2022
@types/prettier is a transitive dependency of `jest`. Version `2.6.1`
introduced a breaking change by increasing the minimum supported
version of typescript to `4.2`. See related issue for more information.

re #20319


----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
corymhall added a commit that referenced this pull request May 12, 2022
@types/prettier is a transitive dependency of `jest`. Version `2.6.1`
introduced a breaking change by increasing the minimum supported
version of typescript to `4.2`. See related issue for more information.

re #20319


----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
wphilipw pushed a commit to wphilipw/aws-cdk that referenced this pull request May 23, 2022
@types/prettier is a transitive dependency of `jest`. Version `2.6.1`
introduced a breaking change by increasing the minimum supported
version of typescript to `4.2`. See related issue for more information.

re aws#20319


----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants