Fix collections.abc imports for Python 3.9 #4860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4860 +/- ##
========================================
Coverage 93.93% 93.93%
========================================
Files 189 189
Lines 14511 14511
========================================
Hits 13631 13631
Misses 880 880
Continue to review full report at Codecov.
|
|
I've been seeing this deprecation in tests for a long time. Glad somebody came here to supply a fix. Looks good! Hope it gets merged in |
joguSD
approved these changes
Feb 11, 2020
|
Thanks for the PR, this looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #4853.
Description of changes:
This was emitting deprecation warning from Python 3.4 and it will stop working in Python 3.9. Reference: python/cpython#10596. There is already awscli/compat.py so import ABCs from
collections_abcthat has Python 2 and 3 compatibility.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
And a heads up: you'll need to migrate off of Nose for testing, it's unmaintained and doesn't support Python 3.9: nose-devs/nose#1099. I'd recommend pytest.