Allow tcp, udp, icmp, all for --protocol param of ec2 create-network-acl-entry #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o accept tcp|udp|icmp|all in addition to the numeric protocol numbers. The docs for the command already say it does this but the actual EC2 operation supports only integer values.
|
Fixes #508 |
|
LGTM. |
|
|
Looks good.
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
Details: * Handling for when lambda returns an error * Handled payload could not be parsed as JSON * Abstracted if the lambda output is an error from the container into LambdaOutputParser * Added handling for X-Amz-Log-Type * Added handling for X-Amz-Invocation-Type * Moved all Request validate to flask.before_request call * Added handling for Query parameters (not supported) * Added handling for unsupported_media_type * Added handling for ServiceError * Added handling for generic 404 Error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the --protocol option of ec2 create-network-acl-entry command to accept tcp|udp|icmp|all in addition to the numeric protocol numbers. The docs for the command already say it does this but the actual EC2 operation supports only integer values.