Support configure get/set with nested attrs #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only works with the full qualified name, i.e.
with the profile specified. For example:
# Works:
aws configure set default.s3.signature_version s3v4
aws configure get default.s3.signature_version s3v4
aws configure set profile.prod.s3.signature_version s3v4
aws configure get profile.prod.s3.signature_version s3v4
# Does not work
aws configure set s3.signature_version s3v4
aws configure get s3.signature_version s3v4
May need to rethink the approach. I've left a failing test
to make it easy to pick right up.
|
LGTM 🚢-it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only works with the full qualified name, i.e.
with the profile specified. For example:
May need to rethink the approach. I've left a failing test
to make it easy to pick right up.
cc @danielgtaylor