Only display --page-size when operation is paginated #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesls
force-pushed
the
page-size-in-pagination
branch
from
d1e885b to
96f3fa1
Compare
|
The only comment I have is would it make sense to include Otherwise, it looks good. 🚢 Thanks for running the integration tests. |
|
Makes sense. I'll update this to include |
This moves the --page-size CLI option to the pagination customization. Before adding the argument, we first verify that not only can the operation be paginated, but also that the pagination configuration supports a limit key. This also means that the --page-size argument is now documented on the man/html page for each operation that supports pagination, making it more clear when this argument can be used. The only other update was that I had to add a page size to the S3 plugin as well.
The rm command does make a ListObjects call in the recursive case, so it makes sense to be consistent and support the --page-size argument for aws s3 rm.
jamesls
force-pushed
the
page-size-in-pagination
branch
from
96f3fa1 to
15d8f4a
Compare
|
@kyleknap Added |
|
Thanks looks good. 🚢 |
jamesls
added a commit
that referenced
this pull request
Oct 31, 2014
|
Merged via accc815 |
kyleknap
added a commit
that referenced
this pull request
Nov 4, 2014
* release-1.5.5: (28 commits) Bumping version to 1.5.5 [EMR] Update create-cluster synopsis [EMR] Update the EMRFS bootstrap action name to be 'Setup EMRFS' [EMR] Remove create-cluster --applications default value and update EMRFS bootstrap action name [EMR] Correct MapR AMI version in create-cluster examples Update docs with shared credentials changes Rename aws_security_token to aws_session_token Fix integration test Update changelog with fix for #956 Add --page-size argument to the aws s3 rm command Only display --page-size when operation is paginated Updated CHANGELOG add frankfurt region Fix typo in error message Updated the travis yml for unittest2 Refactor the clidriver event system Unit and integration test pass for json skeleton Fix arguments with no required setters Accepts input shape of None Add generate skeleton integ test ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the --page-size CLI option to the pagination customization.
Before adding the argument, we first verify that not only can the
operation be paginated, but also that the pagination configuration
supports a limit key. This also means that the --page-size argument
is now documented on the man/html page for each operation that supports
pagination, making it more clear when this argument can be used.
The only other update was that I had to add a page size to the
S3 plugin as well.
cc @danielgtaylor @kyleknap