Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero length frames in Node.js v 10.9 and older fail #199

Closed
seebees opened this issue Aug 28, 2019 · 0 comments · Fixed by #202
Closed

Zero length frames in Node.js v 10.9 and older fail #199

seebees opened this issue Aug 28, 2019 · 0 comments · Fixed by #202

Comments

@seebees
Copy link
Contributor

seebees commented Aug 28, 2019

The Decipher stream wants to be initialized with a update call before final is called.
seebees added a commit to seebees/aws-encryption-sdk-javascript that referenced this issue Aug 28, 2019
@seebees
fix: Zero length frames in old version of Node
b80ac4e 
resolves aws#199

In Node.js versions 10.9 and older will fail to decrypt if decipher.update is not called.
nodejs/node#22538 fixes this.

If the content is empty, push an empty buffer.
@seebees seebees mentioned this issue Aug 28, 2019
Merged
1 task
seebees added a commit that referenced this issue Sep 9, 2019
@seebees
fix: Zero length frames in old version of Node (#202)
c50dfa1 
resolves #199

In Node.js versions 10.9 and older will fail to decrypt if decipher.update is not called.
nodejs/node#22538 fixes this.

If the content is empty, push an empty buffer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Zero length frames in old version of Node seebees/aws-encryption-sdk-javascript
1 participant
@seebees