Add git-secrets check to the GHA. #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateglims
approved these changes
Nov 12, 2020
aggarw13
approved these changes
Nov 12, 2020
This was referenced Nov 12, 2020
|
Wish I had time to understand all this
Secretly of course
Sounds good
temp. 1111
…On Thu, Nov 12, 2020, 6:35 PM Archit Aggarwal ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1385 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOPGRZEDQF7THA5LENR7QPLSPRWLRANCNFSM4TT4TR3A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add git-secrets check to the GHAs. This is a second line of defense against things like an Amazon account number being checked into the repo. The first line of defense is developers running git-secrets in their pre-commit hooks.
See https://github.com/aws/aws-iot-device-sdk-embedded-C/runs/1393292362 for the successful test run.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.