Improve support for alpine linux #675
Merged
+165
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #675 +/- ##
==========================================
- Coverage 95.80% 92.84% -2.96%
==========================================
Files 61 68 +7
Lines 8143 9747 +1604
Branches 0 9747 +9747
==========================================
+ Hits 7801 9050 +1249
- Misses 342 407 +65
- Partials 0 290 +290 ☔ View full report in Codecov by Sentry. |
justsmth
changed the title
justsmth
force-pushed
the
fix-alpine-linux
branch
from
ecbb77e to
e728d8a
Compare
Closed
smittals2
reviewed
Jan 30, 2025
smittals2
reviewed
Jan 30, 2025
smittals2
previously approved these changes
Jan 30, 2025
smittals2
previously approved these changes
Jan 31, 2025
|
I'm happy to report that this PR solves the problem I ran into with #658 |
justsmth
force-pushed
the
fix-alpine-linux
branch
from
844ab10 to
a176239
Compare
skmcgrail
approved these changes
Feb 3, 2025
smittals2
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses: #658
Description of changes:
???-alpine-linux-musltargets to the???-unknown-linux-musltargets that we support.Testing:
CI Job added,
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.