Add BoringSSL Dispatch Test for aarch64 #1093
Conversation
billbo-yang
force-pushed
the
add_arm_dispatch_test
branch
from
9f3f16f to
c1055f7
Compare
crypto/internal.h
Outdated
| // 4: vpaes_encrypt | ||
| // 5: vpaes_set_encrypt_key | ||
| // 6: aesv8_gcm_8x_enc_128 | ||
| #if defined(OPENSSL_AARCH64) |
There was a problem hiding this comment.
Does this need to match the change made in cpucap.c to keep the larger array only?
There was a problem hiding this comment.
I must have missed this when removing the larger array, although it seems like it isn't causing a problem with the code working I'll remove it anyway so that the code will be cleaner / have fewer ifdefs :)
billbo-yang
force-pushed
the
add_arm_dispatch_test
branch
from
9f4e5e1 to
d5bccb0
Compare
These tests are looking to see if we're correctly hitting any special hardware instructions present on the CPU. We support the Intel SHA Extensions on supported x86 processors, hence why we test for it on x86 (as opposed to testing whether we hit the regular assembly instructions) in the dispatch test. However, looking at cpucap/internal.h, I don't see any support for any special SHA hardware extension on aarch64. Given that on x86 we don't test to see if we hit the regular SHA assembly instructions, I don't think we need tests to hit the regular SHA assembly instruction on aarch64 either. Edit: I had missed , which shows that we do in fact take advantage of hardware SHA instructions on armv8. Added the according tests. |
billbo-yang
force-pushed
the
add_arm_dispatch_test
branch
from
d5bccb0 to
a8ca6e7
Compare
…ags to be in line with x86
billbo-yang
force-pushed
the
add_arm_dispatch_test
branch
from
bf84411 to
1f542d8
Compare
Issues:
Addresses CryptoAlg-1873 by unblocking #1045
Description of changes:
Currently AWS-LC only checks whether the correct hardware code is being reached on x86 and x86_64 and not aarch64. This PR fixes that so that we can ensure that the correct code path is taken whenever change OPENSSL_armcap on aarch64 systems.
Call-outs:
N/A
Testing:
Tests pass locally
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.