-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix trailing checksum #3186
Merged
Merged
fix trailing checksum #3186
+226
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9922c19
to
4f32699
Compare
c6d5639
to
826b3a9
Compare
src/aws-cpp-sdk-core/include/aws/core/utils/stream/AwsChunkedStream.h
Outdated
Show resolved
Hide resolved
src/aws-cpp-sdk-core/include/aws/core/utils/stream/AwsChunkedStream.h
Outdated
Show resolved
Hide resolved
src/aws-cpp-sdk-core/include/aws/core/utils/stream/AwsChunkedStream.h
Outdated
Show resolved
Hide resolved
src/aws-cpp-sdk-core/include/aws/core/utils/stream/AwsChunkedStream.h
Outdated
Show resolved
Hide resolved
src/aws-cpp-sdk-core/include/aws/core/utils/stream/AwsChunkedStream.h
Outdated
Show resolved
Hide resolved
src/aws-cpp-sdk-core/include/aws/core/utils/stream/AwsChunkedStream.h
Outdated
Show resolved
Hide resolved
c82a6af
to
d712b17
Compare
SergeyRyabinin
approved these changes
Nov 11, 2024
d712b17
to
e267b78
Compare
sbera87
reviewed
Nov 11, 2024
src/aws-cpp-sdk-core/include/aws/core/utils/stream/AwsChunkedStream.h
Outdated
Show resolved
Hide resolved
sbera87
reviewed
Nov 11, 2024
sbera87
reviewed
Nov 11, 2024
src/aws-cpp-sdk-core/include/aws/core/utils/stream/AwsChunkedStream.h
Outdated
Show resolved
Hide resolved
e267b78
to
c0f0337
Compare
sbera87
reviewed
Nov 11, 2024
sbera87
reviewed
Nov 11, 2024
src/aws-cpp-sdk-core/include/aws/core/utils/stream/AwsChunkedStream.h
Outdated
Show resolved
Hide resolved
e4b72f0
to
b18e244
Compare
sbera87
approved these changes
Nov 11, 2024
c2e65f3
to
e18fdbe
Compare
e18fdbe
to
e6320e0
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
issues/3132
Description of changes:
There was a nasty bit of undefined behavior in the aws-chunked logic for curl. The original implementation assumed that curl would always provide us with a chunk larger than 8kb to per ReadFunc callback. That is simply not true, and it will cause requests where curl calls readfunc with less than 8kb to fail consistently.This buffers the input stream and outputs to curl valid sized chunks, specifically 64kb chunks as S3 specifies as their preference
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.