Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ProtocolTests] #2 Serialize timestamps and enums nested into lists or maps of Query String #3272

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

SergeyRyabinin
Copy link
Contributor

@SergeyRyabinin SergeyRyabinin commented Jan 27, 2025

Issue #, if available:
Protocol tests implementation highlighted an issue in serialization of Query Strings
when the query string has a list of Timestamps.

Description of changes:
Changes how Vector serialization to a query string is done
from

    if(m_queryTimestampListHasBeenSet)
    {
      for(const auto& item : m_queryTimestampList)
      {
        ss << item; // LOOK HERE
        uri.AddQueryStringParameter("TimestampList", ss.str());
        ss.str("");
      }
    }

to

    if(m_queryTimestampListHasBeenSet)
    {
      for(const auto& item : m_queryTimestampList)
      {
        ss << item.ToGmtString(Aws::Utils::DateFormat::ISO_8601); // LOOK HERE
        uri.AddQueryStringParameter("TimestampList", ss.str());
        ss.str("");
      }
    }

No actual diff is generated on existing prod service models.
This will fix only the protocol test client build and will be tested by proto tests once merged.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SergeyRyabinin SergeyRyabinin force-pushed the sr/pt/QueryStringTimestampList branch from 1b472c3 to 330c81e Compare January 27, 2025 22:04
@SergeyRyabinin SergeyRyabinin marked this pull request as ready for review January 27, 2025 22:05
@SergeyRyabinin SergeyRyabinin changed the title Serialize timestamps and enums nested into lists or maps of Query String [ProtocolTests] Serialize timestamps and enums nested into lists or maps of Query String Jan 28, 2025
@SergeyRyabinin SergeyRyabinin force-pushed the sr/pt/QueryStringTimestampList branch from 330c81e to 72df21d Compare January 29, 2025 23:45
@SergeyRyabinin SergeyRyabinin changed the title [ProtocolTests] Serialize timestamps and enums nested into lists or maps of Query String [ProtocolTests] #2 Serialize timestamps and enums nested into lists or maps of Query String Jan 29, 2025
@SergeyRyabinin SergeyRyabinin merged commit 0c27d67 into main Jan 30, 2025
4 of 5 checks passed
@SergeyRyabinin SergeyRyabinin deleted the sr/pt/QueryStringTimestampList branch January 30, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants