Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CRT to v0.30.1 #3283

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update CRT to v0.30.1 #3283

wants to merge 1 commit into from

Conversation

sbiscigl
Copy link
Contributor

@sbiscigl sbiscigl commented Jan 31, 2025

Issue #, if available:

#3281

Description of changes:

  • updates the CRT version.
  • similar to what the IoT v2 SDK has done and update -DBUILD_DEPS=OFF to work with the corrected location of the CRT installation now.
  • removes some std::cout statements i saw that were producing log noise during builds

tested with the following docker build

FROM public.ecr.aws/amazonlinux/amazonlinux:2023

RUN yum groupinstall "Development Tools" -y
RUN yum install -y curl-devel openssl-devel ninja-build cmake3

RUN git clone -b v0.30.1 --recursive https://github.com/awslabs/aws-crt-cpp &&\
    cd aws-crt-cpp &&\
    mkdir build &&\
    cd build &&\
    cmake3 .. -DCMAKE_INSTALL_PREFIX="~/crt-install" &&\
    cmake3 --build . &&\
    cmake3 --install .

RUN git clone -b updateCrt/v0.30.1 --recursive https://github.com/aws/aws-sdk-cpp.git &&\
    cd aws-sdk-cpp &&\
    mkdir build &&\
    cd build &&\
    cmake3 -DBUILD_ONLY="s3" \
        -DCMAKE_PREFIX_PATH="~/crt-install" \
        -DBUILD_DEPS=OFF \
        -DENABLE_TESTING=OFF .. &&\
    cmake3 --build . &&\
    cmake3 --install .

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbera87 sbera87 self-requested a review January 31, 2025 20:48
CMakeLists.txt Outdated
@@ -2,7 +2,7 @@
# SPDX-License-Identifier: Apache-2.0.
#

cmake_minimum_required(VERSION 3.13 FATAL_ERROR)
cmake_minimum_required(VERSION 3.13...3.31)
Copy link

@sfod sfod Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can keep this line as-is, i.e. cmake_minimum_required(VERSION 3.13 FATAL_ERROR).

CRT added ...3.31, because the min version there is 3.9, and it causes cmake warnings if you use cmake 3.31:

% ~/projects/cmake/build_3_31_5/bin/cmake -S . -B build
CMake Deprecation Warning at CMakeLists.txt:6 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.
...

So, you don't have to worry about updating this line with each new cmake release (until 3.13 becomes deprecated, at least).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhhhhhh thanks for that context updating

@sbiscigl sbiscigl force-pushed the updateCrt/v0.30.1 branch 2 times, most recently from ec838e0 to c21716b Compare January 31, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants