Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-crypto): export explicit dependencies on @aws-sdk/types #190

Merged
merged 3 commits into from
Jan 13, 2021

Conversation

alexforsyth
Copy link
Contributor

Issue #, if available:
aws/aws-sdk-js-v3#1842

Description of changes:
Explicitly declare a dependency on @aws-sdk/types for all packages that depend on @aws-sdk types so that downstream consumers of these packages don't have to install @aws-sdk/types themselves. The issue is detailed aws/aws-sdk-js-v3#1842 (comment).

This impacts:

crc32
ie11-detection
random-source-*
sha256-*

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@seebees
Copy link
Contributor

seebees commented Jan 11, 2021

The intention here is to roll back #188 right?

@alexforsyth
Copy link
Contributor Author

alexforsyth commented Jan 12, 2021

The intention here is to roll back #188 right?

@seebees I dont believe rolling back #188 is needed

@seebees
Copy link
Contributor

seebees commented Jan 12, 2021

@alexforsyth I was just making sure I understood the intent here. I went digging and found aws/aws-sdk-js-v3#1842 But I wanted to make sure, for history, that there is a clear link between #188 and this.

@alexforsyth
Copy link
Contributor Author

@seebees yeah #188 was an initial attempt to fix this issue, but after further investigation and discussion among the team this is the correct way to fix things. If needed please message me internally and we can follow up on this there.

@trivikr
Copy link
Member

trivikr commented Jan 12, 2021

Note: The typo in PR title needs to fixed from @aws-types to @aws-sdk/types
cc @alexforsyth

@robin-aws robin-aws changed the title fix(aws-crypto): export explicit dependencies on @aws-types fix(aws-crypto): export explicit dependencies on @aws-sdk/types Jan 13, 2021
@robin-aws robin-aws merged commit b92824c into aws:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants