-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws-crypto): export explicit dependencies on @aws-sdk/types #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
reviewed
Jan 11, 2021
trivikr
reviewed
Jan 11, 2021
The intention here is to roll back #188 right? |
@alexforsyth I was just making sure I understood the intent here. I went digging and found aws/aws-sdk-js-v3#1842 But I wanted to make sure, for history, that there is a clear link between #188 and this. |
seebees
approved these changes
Jan 12, 2021
trivikr
approved these changes
Jan 12, 2021
Note: The typo in PR title needs to fixed from |
robin-aws
changed the title
fix(aws-crypto): export explicit dependencies on @aws-types
fix(aws-crypto): export explicit dependencies on @aws-sdk/types
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-sdk-js-v3#1842
Description of changes:
Explicitly declare a dependency on
@aws-sdk/types
for all packages that depend on@aws-sdk
types so that downstream consumers of these packages don't have to install@aws-sdk/types
themselves. The issue is detailed aws/aws-sdk-js-v3#1842 (comment).This impacts:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.