Skip to content

Commit

Permalink
chore: update protocol tests
Browse files Browse the repository at this point in the history
  • Loading branch information
kuhe committed Sep 24, 2024
1 parent f18e5d0 commit a9e0c6f
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,11 @@ private static boolean filterProtocolTests(
return true;
}

// TODO: Remove when upstream tests update to serialize empty headers.
if (testCase.getId().contains("NullAndEmptyHeaders")) {
return true;
}

if (testCase.getTags().contains("defaults")) {
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6719,7 +6719,7 @@ it("RestJsonNoInputAndOutputNoPayload:Response", async () => {
/**
* Do not send null values, empty strings, or empty lists over the wire in headers
*/
it("RestJsonNullAndEmptyHeaders:Request", async () => {
it.skip("RestJsonNullAndEmptyHeaders:Request", async () => {
const client = new RestJsonProtocolClient({
...clientParams,
requestHandler: new RequestSerializationTestHandler(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3735,7 +3735,7 @@ it("NoInputAndOutput:Response", async () => {
/**
* Do not send null values, empty strings, or empty lists over the wire in headers
*/
it("NullAndEmptyHeaders:Request", async () => {
it.skip("NullAndEmptyHeaders:Request", async () => {
const client = new RestXmlProtocolClient({
...clientParams,
requestHandler: new RequestSerializationTestHandler(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27857,7 +27857,7 @@ it("RestJsonNoInputAndOutputWithJson:ServerResponse", async () => {
/**
* Do not send null or empty headers
*/
it("RestJsonNullAndEmptyHeaders:ServerResponse", async () => {
it.skip("RestJsonNullAndEmptyHeaders:ServerResponse", async () => {
class TestService implements Partial<RestJsonService<{}>> {
NullAndEmptyHeadersServer(input: any, ctx: {}): Promise<NullAndEmptyHeadersServerServerOutput> {
const response = {
Expand Down

0 comments on commit a9e0c6f

Please sign in to comment.