chore: use inline nullish coalescing instead of helper

aws · Jul 15, 2021 · f81ecc7 · f81ecc7
1 parent 46a36f3
commit f81ecc7
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 12 deletions.
diff --git a/...c/main/java/software/amazon/smithy/aws/typescript/codegen/AddEndpointDiscoveryPlugin.java b/...c/main/java/software/amazon/smithy/aws/typescript/codegen/AddEndpointDiscoveryPlugin.java
@@ -108,7 +108,7 @@ public Map<String, Consumer<TypeScriptWriter>> getRuntimeConfigWriters(
             case BROWSER:
                 return MapUtils.of(
                     "endpointDiscoveryEnabledProvider", writer -> {
-                        writer.write("() => Promise.resolve(undefined)");
+                        writer.write("(() => Promise.resolve(undefined))");
                     }
                 );
             case NODE:

diff --git a/.../java/software/amazon/smithy/aws/typescript/codegen/AddEventStreamHandlingDependency.java b/.../java/software/amazon/smithy/aws/typescript/codegen/AddEventStreamHandlingDependency.java
@@ -107,7 +107,7 @@ public Map<String, Consumer<TypeScriptWriter>> getRuntimeConfigWriters(
                     writer.addDependency(TypeScriptDependency.INVALID_DEPENDENCY);
                     writer.addImport("invalidFunction", "invalidFunction",
                             TypeScriptDependency.INVALID_DEPENDENCY.packageName);
-                    writer.openBlock("() => ({", "})", () -> {
+                    writer.openBlock("(() => ({", "}))", () -> {
                         writer.write("handle: invalidFunction(\"event stream request is not supported in browser.\"),");
                     });
                 });
@@ -121,7 +121,7 @@ public Map<String, Consumer<TypeScriptWriter>> getRuntimeConfigWriters(
                     writer.addDependency(TypeScriptDependency.INVALID_DEPENDENCY);
                     writer.addImport("invalidFunction", "invalidFunction",
                             TypeScriptDependency.INVALID_DEPENDENCY.packageName);
-                    writer.openBlock("() => ({", "})", () -> {
+                    writer.openBlock("(() => ({", "}))", () -> {
                         writer.write("handle: invalidFunction(\"event stream request "
                                 + "is not supported in ReactNative.\"),");
                     });

diff --git a/.../java/software/amazon/smithy/aws/typescript/codegen/AddTranscribeStreamingDependency.java b/.../java/software/amazon/smithy/aws/typescript/codegen/AddTranscribeStreamingDependency.java
@@ -67,7 +67,7 @@ public Map<String, Consumer<TypeScriptWriter>> getRuntimeConfigWriters(
                         writer.addDependency(AwsDependency.TRANSCRIBE_STREAMING_MIDDLEWARE);
                         writer.addImport("eventStreamPayloadHandler", "eventStreamPayloadHandler",
                             AwsDependency.TRANSCRIBE_STREAMING_MIDDLEWARE.packageName);
-                        writer.write("() => eventStreamPayloadHandler");
+                        writer.write("(() => eventStreamPayloadHandler)");
                 },
                 "requestHandler", writer -> {
                         writer.addDependency(AwsDependency.TRANSCRIBE_STREAMING_MIDDLEWARE);

diff --git a/packages/smithy-client/src/index.ts b/packages/smithy-client/src/index.ts
@@ -6,7 +6,6 @@ export * from "./extended-encode-uri-component";
 export * from "./get-array-if-single-item";
 export * from "./get-value-from-text-node";
 export * from "./lazy-json";
-export * from "./nullish-coalescing";
 export * from "./parse-utils";
 export * from "./ser-utils";
 export * from "./date-utils";

diff --git a/packages/smithy-client/src/nullish-coalescing.ts b/packages/smithy-client/src/nullish-coalescing.ts