Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: end support for Node.js 10.x #3122

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 3, 2022

Issue

We announced the end of support for Node.js 10.x in the AWS SDK for JavaScript (v3) starting January 1, 2022 back in July.

Description

Bump engines to node >=12.0.0 in package.json

Testing

CI

Additional context

Code change to update engines field for new clients smithy-lang/smithy-typescript#481


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner January 3, 2022 14:04
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2022

Codecov Report

Merging #3122 (4a1fa94) into main (84f98d4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3122   +/-   ##
=======================================
  Coverage   58.72%   58.72%           
=======================================
  Files         572      572           
  Lines       30632    30632           
  Branches     7541     7541           
=======================================
  Hits        17990    17990           
  Misses      12642    12642           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f98d4...4a1fa94. Read the comment docs.

@trivikr trivikr merged commit 7acf18a into aws:main Jan 3, 2022
@trivikr trivikr deleted the update-engines-node-12 branch January 3, 2022 17:26
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants