Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clients): remove unsupported version deprecation warning #3123

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 3, 2022

Issue

No longer needed, as Node.js 10.x support is removed in #3122

Description

Removes call to unsupported version deprecation warning in runtimeConfig

Testing

Testing done in #3122

Additional context

Refs: smithy-lang/smithy-typescript#482


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #3123 (b3a24df) into main (84f98d4) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3123      +/-   ##
==========================================
- Coverage   58.72%   58.70%   -0.03%     
==========================================
  Files         572      572              
  Lines       30632    30612      -20     
  Branches     7541     7541              
==========================================
- Hits        17990    17970      -20     
  Misses      12642    12642              
Impacted Files Coverage Δ
...ts/client-lex-runtime-service/src/runtimeConfig.ts 100.00% <ø> (ø)
...lients/client-mediastore-data/src/runtimeConfig.ts 100.00% <ø> (ø)
clients/client-s3-control/src/runtimeConfig.ts 100.00% <ø> (ø)
clients/client-sts/src/runtimeConfig.ts 100.00% <ø> (ø)
private/aws-protocoltests-ec2/src/runtimeConfig.ts 100.00% <ø> (ø)
...rivate/aws-protocoltests-json/src/runtimeConfig.ts 100.00% <0.00%> (ø)
...ivate/aws-protocoltests-query/src/runtimeConfig.ts 100.00% <0.00%> (ø)
...ate/aws-protocoltests-json-10/src/runtimeConfig.ts 100.00% <0.00%> (ø)
...ate/aws-protocoltests-restxml/src/runtimeConfig.ts 100.00% <0.00%> (ø)
...te/aws-protocoltests-restjson/src/runtimeConfig.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f98d4...b3a24df. Read the comment docs.

@trivikr trivikr merged commit f851a24 into aws:main Jan 3, 2022
@trivikr trivikr deleted the remove-unsupported-version-emit-warning branch January 3, 2022 22:38
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants