Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types): add dist/ to typesVersions TS <4 #2579

Closed
wants to merge 1 commit into from

Conversation

TreTuna
Copy link
Contributor

@TreTuna TreTuna commented Jul 13, 2021

Issue

#2474

Description

While @trivikr fixed the issue with prepublishOnly running on the wrong directory and we are now publishing the dist/types/ts3.4 directory, we are still pointing to types/ts3.4 and the types are not being picked up.

This change updates typeVersions to pick up the proper directories for TS <4.0.

Testing

Made this change, npm pack, installed tarball in my TS 3.6 application, works at intended.

Additional context

Add any other context about the PR here.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 10ba7b3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@401c054). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2579   +/-   ##
=======================================
  Coverage        ?   60.31%           
=======================================
  Files           ?      513           
  Lines           ?    27377           
  Branches        ?     6582           
=======================================
  Hits            ?    16512           
  Misses          ?    10865           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 401c054...10ba7b3. Read the comment docs.

@trivikr
Copy link
Member

trivikr commented Jul 13, 2021

Thank you @TreTuna for the PR!

It's required to be done in codegen as well as all packages.
I've picked up your commit and posted PRs at:

@trivikr trivikr closed this Jul 13, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants