Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): call postinstall-node-version-check in non clients #2590

Closed
wants to merge 3 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 16, 2021

Issue

Internal JS-2727

Description

Calls postinstall-node-version-check in non clients

Testing

Tested in package abort-controller:

$ fnm use 10
Using Node v10.24.1

$ yarn postinstall
yarn run v1.22.10
$ postinstall-node-version-check
(node:21294) NodeDeprecationWarning: The AWS SDK for JavaScript (v3) will
no longer support Node.js v10.24.1 as of January 1, 2022.
To continue receiving updates to AWS services, bug fixes, and security
updates please upgrade to Node.js 12.x or later.

More information can be found at: https://a.co/1l6FLnu
Done in 0.11s.

$ fnm use 12
Using Node v12.22.1

$ yarn postinstall
yarn run v1.22.10
$ postinstall-node-version-check
Done in 0.10s.

Testing of the util package done in #2585


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 69d8df7
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr
Copy link
Member Author

trivikr commented Jul 16, 2021

CI error:

error An unexpected error occurred: "ENOENT: no such file or directory, chmod '/codebuild/output/src809350860/src/github.com/aws/aws-sdk-js-v3/clients/client-sso/node_modules/.bin/postinstall-node-version-check'".
info If you think this is a bug, please open a bug report with the information provided in "/codebuild/output/src809350860/src/github.com/aws/aws-sdk-js-v3/yarn-error.log".

I wonder why this error is thrown, as postinstall script is not added to client-sso

@trivikr
Copy link
Member Author

trivikr commented Jul 20, 2021

Closing as we would be calling emitWarningIfUnsupportedVersion in runtimeConfig after #2574 is merged.

@trivikr trivikr closed this Jul 20, 2021
@github-actions
Copy link

github-actions bot commented Aug 4, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
@trivikr trivikr deleted the postinstall-non-clients-final branch October 7, 2021 22:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants