Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clients): bump target to ES2020 and remove outdated libs #4006

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 30, 2022

Issue

Internal JS-3616
Blog post: Announcing the end of support for Internet Explorer 11 in the AWS SDK for JavaScript (v3)

This PR will be rebased and made ready after v3.182.0 release on Sep 30th.

Description

Bumps target to ES2020 and removes outdated libs in clients

Testing

Before: class is converted to function in ES5
$ client-acm> yarn clean && yarn build:include:deps

$ client-acm> sed -n 15,20p dist-es/ACM.js         
import { RequestCertificateCommand, } from "./commands/RequestCertificateCommand";
import { ResendValidationEmailCommand, } from "./commands/ResendValidationEmailCommand";
import { UpdateCertificateOptionsCommand, } from "./commands/UpdateCertificateOptionsCommand";
var ACM = (function (_super) {
    __extends(ACM, _super);
    function ACM() {
After: class is retained as class in ES2020
$ client-acm> yarn clean && yarn build:include:deps

$ client-acm> sed -n 15,20p dist-es/ACM.js 
import { ResendValidationEmailCommand, } from "./commands/ResendValidationEmailCommand";
import { UpdateCertificateOptionsCommand, } from "./commands/UpdateCertificateOptionsCommand";
export class ACM extends ACMClient {
    addTagsToCertificate(args, optionsOrCb, cb) {
        const command = new AddTagsToCertificateCommand(args);
        if (typeof optionsOrCb === "function") {

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review September 30, 2022 19:31
@trivikr trivikr requested a review from a team as a code owner September 30, 2022 19:31
@trivikr trivikr merged commit 6a7fea4 into aws:main Sep 30, 2022
@trivikr trivikr deleted the tsconfig-clients-es-2020 branch September 30, 2022 19:34
@vincemtnz
Copy link

Does this mean node v12 is no longer supported a month earlier than planned? (unless one also configures their bundler target + polyfills?)

@kuhe
Copy link
Contributor

kuhe commented Oct 4, 2022

This only affects the dist-es ESM distributions. NodeJS uses dist-cjs.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants