-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): use @smithy types and protocol-http #4722
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
changed the title
Use smithy types protocol http
Use @smithy types and protocol-http
May 12, 2023
kuhe
approved these changes
May 15, 2023
srchase
force-pushed
the
use-smithy-types-protocol-http
branch
from
May 16, 2023 20:47
a910be7
to
8b16343
Compare
MYoung25
approved these changes
May 16, 2023
Build failure: lerna ERR! yarn run build exited 1 in '@aws-sdk/client-lex-runtime-v2'
lerna ERR! yarn run build stdout:
$ concurrently 'yarn:build:cjs' 'yarn:build:es' 'yarn:build:types'
[build:types] $ tsc -p tsconfig.types.json
[build:cjs] $ tsc -p tsconfig.cjs.json
[build:es] $ tsc -p tsconfig.es.json
[build:types] src/protocols/Aws_restJson1.ts(20,19): error TS2300: Duplicate identifier '__SerdeContext'.
[build:types] src/protocols/Aws_restJson1.ts(23,50): error TS2300: Duplicate identifier '__SerdeContext'.
[build:types] error Command failed with exit code 1.
[build:types] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[build:types] yarn run build:types exited with code 1
[build:cjs] src/protocols/Aws_restJson1.ts(20,19): error TS2300: Duplicate identifier '__SerdeContext'.
[build:cjs] src/protocols/Aws_restJson1.ts(23,50): error TS2300: Duplicate identifier '__SerdeContext'.
[build:cjs] error Command failed with exit code 2.
[build:cjs] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[build:cjs] yarn run build:cjs exited with code 2
[build:es] src/protocols/Aws_restJson1.ts(20,19): error TS2300: Duplicate identifier '__SerdeContext'.
[build:es] src/protocols/Aws_restJson1.ts(23,50): error TS2300: Duplicate identifier '__SerdeContext'.
[build:es] error Command failed with exit code 2.
[build:es] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[build:es] yarn run build:es exited with code 2
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
lerna ERR! yarn run build stderr:
error Command failed with exit code 1.
lerna ERR! yarn run build exited 1 in '@aws-sdk/client-lex-runtime-v2'
lerna WARN complete Waiting for 72 child processes to exit. CTRL-C to exit immediately.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. |
trivikr
changed the title
Use @smithy types and protocol-http
feat(deps): use @smithy types and protocol-http
May 16, 2023
Fix for the EventStream Successful build of EventStream client:
|
trivikr
approved these changes
May 16, 2023
1 task
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue number, if available, prefixed with "#"
Description
This PR updates the codegen to use the
@smithy/types
and@smithy/protocol-http
. The latter replaces the@aws-sdk/protocol-http
package after its migration to the smithy-typescript repository.The codegen for clients is included.
Testing
After updating codegen, published smithy-typescript changes locally and ran
yarn generate-clients && yarn
to update yarn lock file, and tested withyarn test:server-protocols && yarn test:protocols
.Additional context
This change pairs with smithy-lang/smithy-typescript#766.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.