Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update fast-xml-parser for 3.6.4 release #4885

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 26, 2023

Issue

Internal JS-4435

Description

Update fast-xml-parser to 4.2.5 to release @aws-sdk/[email protected]

Testing

$ client-s3> yarn test:unit
yarn run v1.22.19
$ mocha **/cjs/**/*.spec.js


  endpoint
    ✓ users can override endpoint from client.

  Accesspoint ARN
    ✓ should succeed with access point ARN
    ✓ should sign request with region from ARN is useArnRegion is set
    ✓ should succeed with outposts ARN

  Throw 200 response
    ✓ should throw if CopyObject() return with 200 and empty payload
    ✓ should throw if CopyObject() return with 200 and error preamble
    ✓ should throw if UploadPartCopy() return with 200 and empty payload
    ✓ should throw if UploadPartCopy() return with 200 and error preamble
    ✓ should throw if CompleteMultipartUpload() return with 200 and empty payload
    ✓ should throw if CompleteMultipartUpload() return with 200 and error preamble


  10 passing (38ms)

Done in 0.52s.
$ aws-sdk-js-v3>  yarn test:integration-legacy -t @s3
yarn run v1.22.19
$ cucumber-js --fail-fast -t @s3
..................................................................................................................................................................................................................

24 scenarios (24 passed)
138 steps (138 passed)
0m12.435s

npm tarball for testing: aws-sdk-client-s3-3.6.4.tgz

The tarballs were created by:


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

@stocaaro stocaaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed this change updates amplify-js.

@trivikr trivikr merged commit cbc5ad5 into aws:v3.6.4-2023-06-26 Jun 26, 2023
@trivikr trivikr deleted the v3.6.4-fast-xml-parser branch June 26, 2023 22:54
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants