Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update fast-xml-parser for 3.54.3 release #4887

Closed

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 26, 2023

Issue

Internal JS-4435

Description

Update fast-xml-parser to 4.2.5 to release:

Testing

Integration tests are successful for sts

$ aws-sdk-js-v3>  yarn test:integration:legacy -t @sts 
yarn run v1.22.17
$ cucumber-js --fail-fast -t @sts
...........

2 scenarios (2 passed)
7 steps (7 passed)
0m00.110s (executing steps: 0m00.073s)
Done in 0.97s.

Tarballs to be published:

The tarballs were created by:

  • git clean -dfx
  • yarn
  • yarn lerna run --scope @aws-sdk/client-sts --scope @aws-sdk/client-cognito-identity --scope @aws-sdk/client-cognito-identity-provider --include-dependencies build
  • yarn lerna run --scope @aws-sdk/client-sts --scope @aws-sdk/client-cognito-identity --scope @aws-sdk/client-cognito-identity-provider build:types:downlevel
  • yarn update:versions:current
  • yarn lerna exec --scope @aws-sdk/client-sts --scope @aws-sdk/client-cognito-identity --scope @aws-sdk/client-cognito-identity-provider npm pack

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review June 26, 2023 21:18
@trivikr trivikr requested a review from a team as a code owner June 26, 2023 21:18
@trivikr
Copy link
Member Author

trivikr commented Jun 26, 2023

Not needed, as aws-amplify is not impacted. Requested and confirmed internally in JS-4435.

@trivikr trivikr closed this Jun 26, 2023
@trivikr trivikr deleted the v3.54.3-fast-xml-parser branch June 26, 2023 22:26
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants