Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): pkg.json merge behavior #4954

Merged
merged 3 commits into from
Jul 11, 2023
Merged

fix(codegen): pkg.json merge behavior #4954

merged 3 commits into from
Jul 11, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Jul 11, 2023

Issue

detected by internal builds

Description

  • component 1: use semver to take the higher version when merging smithy-ts codegen output package.json to our package.json files in clients
  • component 2: check runtime dependencies in the entire repo and throw error when inconsistencies are observed

example:

 * There is more than one version of a declared runtime dependency
 * @smithy/middleware-endpoint {
 *   '^1.0.2': '350 locations',
 *   '^1.0.1': [
 *     '@aws-sdk/lib-storage',
 *     '@aws-sdk/middleware-sdk-ec2',
 *     '@aws-sdk/middleware-sdk-rds',
 *     '@aws-sdk/s3-presigned-post',
 *     '@aws-sdk/s3-request-presigner'
 *   ]
 * }

Testing

yarn generate-clients

@kuhe kuhe requested review from a team as code owners July 11, 2023 18:56
@kuhe kuhe merged commit 4fc0b7f into aws:main Jul 11, 2023
@kuhe kuhe deleted the fix/codegen branch July 11, 2023 19:29
@jd-carroll
Copy link

Any idea when the next release will be cut?

We just spent the afternoon trying to understand an issue that is fixed with this PR.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants