Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware-sdk-s3): remove error name check to allow for region redirect for HEAD operations #5425

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

siddsriv
Copy link
Contributor

Issue

#5388

Description

Removes the check for error name as HEAD operations don't have that error name (but still have the 301 status code). This allows users to opt in for region redirection for HEAD operations as well.

Testing

E2E tests pass

 PASS  src/region-redirect-middleware.e2e.spec.ts (19.069 s)
  S3 Global Client Test
    ✓ Should be able to put objects following region redirect (8377 ms)
    ✓ Should be able to get objects following region redirect (3847 ms)
    ✓ Should delete objects following region redirect (907 ms)

Test Suites: 1 passed, 1 total
Tests:       3 passed, 3 total
Snapshots:   0 total
Time:        19.112 s
Ran all test suites.
Done in 19.81s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@siddsriv siddsriv requested a review from a team as a code owner October 27, 2023 17:02
@siddsriv siddsriv merged commit eed5dcc into aws:main Oct 31, 2023
2 checks passed
@siddsriv siddsriv deleted the s3-head-rrm branch October 31, 2023 15:51
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants