Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): preprocess AwsQuery error to shapeId in waiter errorType #6501

Merged
merged 4 commits into from
Sep 25, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
/*
* Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the short header, not 2019

*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/

package software.amazon.smithy.aws.typescript.codegen;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import software.amazon.smithy.aws.traits.protocols.AwsQueryErrorTrait;
import software.amazon.smithy.model.Model;
import software.amazon.smithy.model.knowledge.TopDownIndex;
import software.amazon.smithy.model.node.ObjectNode;
import software.amazon.smithy.model.shapes.OperationShape;
import software.amazon.smithy.model.shapes.ServiceShape;
import software.amazon.smithy.model.shapes.Shape;
import software.amazon.smithy.model.shapes.ShapeId;
import software.amazon.smithy.model.traits.ErrorTrait;
import software.amazon.smithy.model.transform.ModelTransformer;
import software.amazon.smithy.typescript.codegen.TypeScriptSettings;
import software.amazon.smithy.typescript.codegen.integration.TypeScriptIntegration;
import software.amazon.smithy.utils.SmithyInternalApi;
import software.amazon.smithy.waiters.Acceptor;
import software.amazon.smithy.waiters.Matcher;
import software.amazon.smithy.waiters.WaitableTrait;
import software.amazon.smithy.waiters.Waiter;


@SmithyInternalApi
public final class ProcessAwsQueryWaiters implements TypeScriptIntegration {

@Override
public Model preprocessModel(Model model, TypeScriptSettings settings) {
Map<String, String> errorCodeToShapeId = new HashMap<>();

ServiceShape serviceShape = settings.getService(model);
TopDownIndex topDownIndex = TopDownIndex.of(model);
for (OperationShape operationShape : topDownIndex.getContainedOperations(serviceShape)) {
for (ShapeId errorShapeId : operationShape.getErrors()) {
Shape errorShape = model.expectShape(errorShapeId);
if (errorShape.hasTrait(ErrorTrait.class) && errorShape.hasTrait(AwsQueryErrorTrait.class)) {
AwsQueryErrorTrait awsQueryTrait = errorShape.expectTrait(AwsQueryErrorTrait.class);
errorCodeToShapeId.put(awsQueryTrait.getCode(), errorShape.getId().getName());
}
}
}

List<Shape> modifiedShapes = new ArrayList<>();

for (OperationShape operationShape : topDownIndex.getContainedOperations(serviceShape)) {
OperationShape.Builder operationBuilder = operationShape.toBuilder();
if (operationShape.hasTrait(WaitableTrait.class)) {
operationBuilder.removeTrait(WaitableTrait.ID);
WaitableTrait waiterTrait = operationShape.expectTrait(WaitableTrait.class);
WaitableTrait.Builder waitableTraitBuilder = (WaitableTrait.Builder) waiterTrait.toBuilder();
for (Map.Entry<String, Waiter> entry : waiterTrait.getWaiters().entrySet()) {
String name = entry.getKey();
Waiter waiter = entry.getValue();
Waiter.Builder waiterBuilder = (Waiter.Builder) waiter.toBuilder();
waiterBuilder.clearAcceptors();
for (Acceptor acceptor : waiter.getAcceptors()) {
ObjectNode acceptorNode = acceptor.toNode().expectObjectNode();
Matcher matcher = acceptor.getMatcher();
if (matcher instanceof Matcher.ErrorTypeMember) {
ObjectNode matcherNode = matcher.toNode().expectObjectNode();

String errorCode = matcherNode.expectStringMember("errorType").getValue();
if (errorCodeToShapeId.containsKey(errorCode)) {
matcherNode = matcherNode.toBuilder()
.withMember("errorType", errorCodeToShapeId.get(errorCode))
.build();

acceptorNode = acceptorNode.toBuilder()
.withMember("matcher", matcherNode)
.build();
}
}
waiterBuilder.addAcceptor(Acceptor.fromNode(acceptorNode));
}
waitableTraitBuilder.put(name, waiterBuilder.build());
}
operationBuilder.addTrait(waitableTraitBuilder.build());
}
modifiedShapes.add(operationBuilder.build());
}

if (!modifiedShapes.isEmpty()) {
ModelTransformer transformer = ModelTransformer.create();
model = transformer.replaceShapes(model, modifiedShapes);
}

return model;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ software.amazon.smithy.aws.typescript.codegen.AddDocumentClientPlugin
software.amazon.smithy.aws.typescript.codegen.AddEndpointDiscoveryPlugin
software.amazon.smithy.aws.typescript.codegen.AddHttpChecksumDependency
software.amazon.smithy.aws.typescript.codegen.AddSigv4aPlugin
software.amazon.smithy.aws.typescript.codegen.ProcessAwsQueryWaiters
software.amazon.smithy.aws.typescript.codegen.auth.http.integration.AwsSdkCustomizeHttpBearerTokenAuth
software.amazon.smithy.aws.typescript.codegen.auth.http.integration.SupportSigV4Auth
software.amazon.smithy.aws.typescript.codegen.auth.http.integration.AwsSdkCustomizeSigV4Auth
Expand Down
Loading