Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch between SDK and SDK's documentation for S3 #1653

Closed
ciceroneves opened this issue Jul 2, 2020 · 2 comments
Closed

Mismatch between SDK and SDK's documentation for S3 #1653

ciceroneves opened this issue Jul 2, 2020 · 2 comments
Labels
bug This issue is a bug. doc-apireference documentation This is a problem with documentation. p3 This is a minor priority issue queued s3

Comments

@ciceroneves
Copy link

Description

In AWS SDK .NET documentation it states the AmazonS3Config has the property name ConnectionLimit which inherited from Amazon.Runtime.ClientConfig
When I try to set this value in my project using the lastest version of the SDK, the compiler says that this property does not exist

Link for documentation https://docs.aws.amazon.com/sdkfornet/v3/apidocs/items/S3/TS3Config.html

Reproduction Steps

Create a .net standard project
Add the AWSSDK.S3 nuget package (version 3.3.111.20)
Try to instantiate an AmazonS3Config object and set the ConnectionLimit property

new AmazonS3Config
{
    ConnectionLimit = 42
});

Logs

N/A

Environment

  • SDK Version: 3.3.111.20
  • Package Version: 3.3.111.20
  • OS Info: Windows 10
  • Build Environment Visual Studio
  • Targeted .NET Platform: netstandard2.0

This is a 🐛 bug-report

@ciceroneves ciceroneves added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 2, 2020
@NGL321 NGL321 added s3 needs-reproduction This issue needs reproduction. p1 This is a high priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Jul 8, 2020
@NGL321 NGL321 self-assigned this Jul 8, 2020
@NGL321 NGL321 added documentation This is a problem with documentation. B labels Sep 9, 2020
@ashishdhingra
Copy link
Contributor

ashishdhingra commented Nov 2, 2020

Looks like ConnectionLimit is only available for .NET Framework as indicated by code

. However, documentation needs to properly indicate that it is framework specific. Hence added doc-apireference label.

@hunanniu hunanniu added the queued label May 3, 2021
@ashishdhingra ashishdhingra removed needs-reproduction This issue needs reproduction. p1 This is a high priority issue labels Jun 23, 2021
@NGL321 NGL321 removed their assignment Dec 29, 2021
@ashishdhingra ashishdhingra added p2 This is a standard priority issue p3 This is a minor priority issue and removed B p2 This is a standard priority issue labels Nov 2, 2022
gcbeattyAWS added a commit to gcbeattyAWS/aws-sdk-net that referenced this issue Oct 18, 2024
gcbeattyAWS added a commit that referenced this issue Oct 22, 2024
* Updates the documentation for ConnectionLimit to fix #1653
Copy link

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. doc-apireference documentation This is a problem with documentation. p3 This is a minor priority issue queued s3
Projects
None yet
Development

No branches or pull requests

4 participants