Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typos in comments and docs #1761

Merged
merged 3 commits into from
Nov 11, 2022
Merged

typos in comments and docs #1761

merged 3 commits into from
Nov 11, 2022

Conversation

mycaule
Copy link
Contributor

@mycaule mycaule commented Nov 10, 2022 •
edited
Loading

Feature or Bugfix

  • Bugfix

Detail

This read_parquet documentation contained a few typos with examples using CSV not Parquet. It might come from copy pasting the original code template for read_csv

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: d9b5609
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

kukushking
kukushking approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the corrections!

@mycaule
Copy link
Contributor Author

mycaule commented Nov 10, 2022 •
edited
Loading

Thanks for the corrections!

I used these two trick to pass the linting errors not sure it will render correctly in HTML though...
PyCQA/pydocstyle#234 (comment)
pylint-dev/pylint#2957 (comment)

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: cebd61d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: dc68bdf
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 6b10c15
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido jaidisido merged commit 03fdd9b into aws:main Nov 11, 2022
@mycaule mycaule deleted the patch-1 branch November 11, 2022 12:02
@kukushking kukushking added this to the 2.18.0 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaidisido jaidisido jaidisido approved these changes

@kukushking kukushking kukushking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mycaule @malachi-constant @kukushking @jaidisido