Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlock in CodeWhispererStatusBarWidget #4967

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

rli
Copy link
Contributor

@rli rli commented Oct 14, 2024

CodeWhispererStatusBarWidget#getSelectedValue is called under EDT, but may cause ProfileWatcher to be indirectly initialized on the background through ToolkitConnectionManager#activeConnectionForFeature. However ProfileWatcher requires EDT to initialize correctly since it relies on VFS events to propagate on EDT before it returns

Description

#4966

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rli rli requested review from a team as code owners October 14, 2024 18:15
Copy link

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@rli rli merged commit 379b1ec into main Oct 16, 2024
12 of 16 checks passed
@rli rli deleted the rli/codewhisperer-widget-deadlock branch October 16, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants