Handle Aiohttp Exceptions as valid responses #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a bug that till now handled all exceptions as just 500, while valid Aiohttp Exceptions have to be handled as valid responses, they are used to notify none 2XX responses, perhaps a 401 is notified with a HTTPUnauthorized exception.
|
Please, considere it in WIP I will add some changes. With the current code the Aiohttp exception is never reraised to the upper middlewares. |
|
Please, considere it in WIP I will add some changes. With the current code the Aiohttp exception is never reraised to the upper middlewares. Better close it, I will reopen it in while |
|
Without this PR all none 2XX response code are considered 500, so it needs to be fixed. The PR is ready to be reviewed. Sorry to be late, I've seen that you have already released the 1.1. but most likely this PR will deserve also a new release. /cc @haotianw465 |
haotianw465
approved these changes
May 16, 2018
|
Sorry to bother you @haotianw465 , do you have any ETA for the next release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that till now handled all exceptions as just 500,
while valid Aiohttp Exceptions have to be handled as valid responses.
They are used to notify none 2XX responses, perhaps a 401 is notified
with an
HTTPUnauthorizedexception.