Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vsphere template envvar in conformance test #4069

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

g-gaston
Copy link
Member

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@g-gaston g-gaston requested a review from jaxesn November 15, 2022 15:57
@g-gaston
Copy link
Member Author

/cherry-pick release-0.12

@eks-distro-pr-bot
Copy link
Contributor

@g-gaston: once the present PR merges, I will cherry-pick it on top of release-0.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@g-gaston
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: g-gaston

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@g-gaston g-gaston force-pushed the conformance-vsphere-templates branch from 7a28c52 to ae5f6e9 Compare November 15, 2022 17:24
@eks-distro-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@g-gaston g-gaston force-pushed the conformance-vsphere-templates branch from ae5f6e9 to a2b7744 Compare November 15, 2022 17:24
@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 15, 2022
@g-gaston g-gaston added the lgtm label Nov 15, 2022
@g-gaston
Copy link
Member Author

forced pushed to trigger jobs since they seemed stuck, no changes

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #4069 (a2b7744) into main (91e5fb8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4069   +/-   ##
=======================================
  Coverage   67.56%   67.56%           
=======================================
  Files         395      395           
  Lines       32005    32005           
=======================================
  Hits        21625    21625           
  Misses       8959     8959           
  Partials     1421     1421           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eks-distro-pr-bot
Copy link
Contributor

@g-gaston: new pull request created: #4073

In response to this:

/cherry-pick release-0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants