Improve controller manager logs #4115
Conversation
eks-distro-bot
added
the
size/L
| k8s.io/apimachinery v0.24.3 | ||
| k8s.io/apiserver v0.24.2 | ||
| k8s.io/client-go v0.24.2 | ||
| k8s.io/api v0.25.4 |
There was a problem hiding this comment.
Why all the go mod changes?
There was a problem hiding this comment.
I bumped controller-runtime to use their latest logger attributes (reconcileID for example).
Also, go upgraded some modules when adding component-base.
g-gaston
force-pushed
the
controller-logs
branch
from
a08556f to
056716c
Compare
Codecov Report
@@ Coverage Diff @@
## main #4115 +/- ##
==========================================
- Coverage 67.59% 67.58% -0.01%
==========================================
Files 397 397
Lines 32072 32064 -8
==========================================
- Hits 21679 21671 -8
Misses 8966 8966
Partials 1427 1427
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
/approve |
This now makes use of the tooling provided by upstream controller-runtime and component-base/logs. As a consequence, the manager now takes a standard set of flags to configure logging. The default logging format is configured to json, it's the direction upstream is going duwe to its tooling support. For tilt, using text for now until we provide better tooling to analyze the logs. Instead of injecting a logger in the reconciler on construction, we now use contextual logging. The benefit here is controller-runtime will inject a default set of values that uniquely identify the reconcile request.
g-gaston
force-pushed
the
controller-logs
branch
from
056716c to
721b5fc
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: g-gaston The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes
This now makes use of the tooling provided by upstream controller-runtime and component-base/logs. As a consequence, the manager now takes a standard set of flags to configure logging.
The default logging format is configured to json, it's the direction upstream is going due to its tooling support. For tilt, using text for now until we provide better tooling to analyze the logs.
Instead of injecting a logger in the reconciler on construction, we now use contextual logging. The benefit here is controller-runtime will inject a default set of values that uniquely identify the reconcile request.
More info
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.