chore: improve error message when a non-jsii dependency is not bundled #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of outputting a very terse 'Unable to locate module', which misleads users into believing the module cannot be resolved by the compiler, use a longer error message that clearly states the jsii Assembly could not be located, and that non-jsii dependencies must be bundled. Fixes #1636
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
suggested changes
May 12, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
approved these changes
May 12, 2020
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
chore: improve error message when a non-jsii dependency is not bundled (#1651)
Instead of outputting a very terse 'Unable to locate module', which misleads users into believing
the module cannot be resolved by the compiler, use a longer error message that clearly states the
jsii Assembly could not be located, and that non-jsii dependencies must be bundled.
Fixes #1636
End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.