Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use "go test" instead of "ginkgo" #2057

Merged
merged 1 commit into from
Jul 5, 2022
Merged

chore: use "go test" instead of "ginkgo" #2057

merged 1 commit into from
Jul 5, 2022

Conversation

ellistarn
Copy link
Contributor

@ellistarn ellistarn commented Jul 5, 2022 •
edited
Loading

Fixes #

Description
Uses go test instead of ginkgo cli. ginkgo is still used as a library.

How was this change tested?
Manually tested and injected failures.

  • make test
  • make battletest
  • make ci

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ellistarn ellistarn requested a review from a team as a code owner July 5, 2022 20:37
@ellistarn ellistarn requested a review from njtran July 5, 2022 20:37
@netlify
Copy link

netlify bot commented Jul 5, 2022 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit d63d6b5
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62c4a2aaeeb02d00098cd37b

@ellistarn ellistarn changed the title chore: use instead of chore: use "go test" instead of "ginkgo" Jul 5, 2022
bwagner5
bwagner5 approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@bwagner5 bwagner5 merged commit 21ff268 into aws:main Jul 5, 2022
@ellistarn ellistarn deleted the gotest branch July 5, 2022 21:58
This was referenced Jul 13, 2022
Closed
Merged
@suket22 suket22 mentioned this pull request Jul 21, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwagner5 bwagner5 bwagner5 approved these changes

@njtran njtran Awaiting requested review from njtran njtran is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ellistarn @bwagner5