-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support providing multiple dns ips #7546
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
This is a critical feature that needs to be supported, as there are valid use cases for using CoreDNS as a secondary cluster DNS in setups where node-local-DNS is in use. It seems that the PR might be inadvertently breaking the
We should update the implementation to ensure IPv6 configurations remain unaffected. |
@heshamelsherif97 Which concerns do you have about breaking this function? Of course, it could break it you pass in an ipv4 address in an ipv6 cluster for DNS resolution. |
I'm specifically referring to this line:
It appears that the current check assumes the first element in the list determines whether Karpenter should pass the However, with this new change allowing multiple IPs to be provided, this approach may not be entirely correct in my humble opinion. |
Fixes #4836
Description
Updates all linux code paths to use all provided dns server ip addresses. Which are provided via the Ec2NodeTemplate.
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.