Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python Wrapper for RCF and Fix Error Message #404

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

kaituo
Copy link
Collaborator

@kaituo kaituo commented Jul 8, 2024

Issue #, if available:

  • Added a Python wrapper to enable calling RCF from Python.
  • Fixed an error message that previously referenced the wrong variable.

Testing:

  • Manually tested the Python binding to ensure it works correctly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

- Added a Python wrapper to enable calling RCF from Python.
- Fixed an error message that previously referenced the wrong variable.

Testing:
- Manually tested the Python binding to ensure it works correctly.

Signed-off-by: Kaituo Li <[email protected]>
@kaituo kaituo requested a review from greaa-aws July 8, 2024 23:24
Copy link
Collaborator

@greaa-aws greaa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, matches my code for python bindings.

Only point I'd raise is high-level: why does TRCF only have a process() method while RCF has score(), update(), etc? Can we add a little more detail to what TRCF.process() does - is it basically "score and update"?

In a future commit I think we'd also want to add more on the documentation side, especially regarding the RCF / TRCF parameters and their meaning.

@kaituo
Copy link
Collaborator Author

kaituo commented Jul 12, 2024

Looks good to me, matches my code for python bindings.

Only point I'd raise is high-level: why does TRCF only have a process() method while RCF has score(), update(), etc? Can we add a little more detail to what TRCF.process() does - is it basically "score and update"?

In a future commit I think we'd also want to add more on the documentation side, especially regarding the RCF / TRCF parameters and their meaning.

process does more than score/update. It includes all of the pre and post processing besides score/update. I added more description on the process method parameters.

@kaituo kaituo merged commit d076571 into aws:main Jul 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants