Upgrade SKLearn to 1.2.1 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabunday
previously approved these changes
Feb 15, 2023
|
You can add a new release when this is merged https://github.com/aws/sagemaker-scikit-learn-container/releases |
sure, thanks for the reference |
| @@ -184,10 +184,10 @@ def test_load_and_unload_two_models(): | |||
| res_json = json.loads(res) | |||
| assert res_json['status'] == 'Workers scaled' | |||
|
|
|||
| code, res = make_invocation_request('0.0, 0.0, 0.0, 0.0, 0.0, 0.0', model_name_0) | |||
There was a problem hiding this comment.
Have you ran the container Integ tests?
There was a problem hiding this comment.
yes they ran as a part of codebuild, and that led me to this particular change. By mistake I retrained the models using the dummy data which had 5 features but these requests were having 6 which I realized later and thought its easier and faster to make a change here.
NikhilRaverkar
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.