Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RingBuffer panic due to out of bounds index #282

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Fix RingBuffer panic due to out of bounds index #282

merged 1 commit into from
Apr 7, 2021

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Apr 2, 2021 •
edited by jasdel
Loading

Fixes an index out of bounds in the RingBuffer implementation.

Fixes aws/aws-sdk-go-v2#1200

@skmcgrail skmcgrail requested review from jasdel and skotambkar April 2, 2021 18:06
@skmcgrail skmcgrail requested a review from skotambkar April 5, 2021 17:54
@skotambkar skotambkar merged commit 481242f into aws:main Apr 7, 2021
@purpleidea
Copy link

No call out of thanks in the commit for tracking down bugs? ;) Oh well.

skotambkar added a commit that referenced this pull request Apr 8, 2021
@skotambkar
add changelog entry for release v1.3.1 (#284)
f1eb091 
### Smithy Go module
* `transport/http`: Loosen endpoint hostname validation to allow specifying port numbers. ([#279](#279))
* `io`: Fix RingBuffer panics due to out of bounds index. ([#282](#282))
@skmcgrail skmcgrail deleted the bugRingBuffer branch November 8, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotambkar skotambkar skotambkar approved these changes

@jasdel jasdel jasdel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic when missing credentials
4 participants
@skmcgrail @purpleidea @jasdel @skotambkar