-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Tyrus with OkHttp #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, okhttp seems a lot more modern and easier to use.
app/src/main/java/com/amazonaws/kinesisvideo/demoapp/activity/WebRtcActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/amazonaws/kinesisvideo/demoapp/activity/WebRtcActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/amazonaws/kinesisvideo/signaling/okhttp/WebSocketClient.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/amazonaws/kinesisvideo/signaling/okhttp/WebSocketClient.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/amazonaws/kinesisvideo/signaling/okhttp/WebSocketClient.java
Show resolved
Hide resolved
app/src/main/java/com/amazonaws/kinesisvideo/signaling/okhttp/WebSocketClient.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/amazonaws/kinesisvideo/signaling/okhttp/WebSocketClient.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/amazonaws/kinesisvideo/signaling/okhttp/WebSocketClient.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/amazonaws/kinesisvideo/signaling/okhttp/WebSocketClient.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/amazonaws/kinesisvideo/demoapp/activity/WebRtcActivity.java
Show resolved
Hide resolved
app/src/main/java/com/amazonaws/kinesisvideo/signaling/SignalingListener.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled the latest and deployed the app onto the Samsung Galaxy S22 Ultra and it was able to connect to the JS as master and viewer on both LTE and WiFi. Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic @niyatim23 !!
Issue #, if available:
Description of changes:
compileSdk
andtargetSdk
to 34aws-version
from '2.73.0' to '2.75.0'com.google.code.gson:gson
from '2.8.9' to '2.10.1'com.google.android.material:material
from '1.9.0' to '1.11.0'androidx.test.espresso:espresso-core
from '3.4.0' to '3.5.1'!mIceServerList.isEmpty()
instead ofmIceServerList.size() > 0
Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.