Add comments with instructions for when using an app client without a client secret #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirknightj
reviewed
May 15, 2024
| let cognitoIdentityUserPoolId = "REPLACEME" | ||
| let cognitoIdentityUserPoolAppClientId = "REPLACEME" | ||
| let cognitoIdentityUserPoolAppClientSecret = "REPLACEME" | ||
| let cognitoIdentityUserPoolAppClientSecret = "REPLACEME" // <- Leave blank "" if AppClient does not use a client secret. |
There was a problem hiding this comment.
I believe you would also need to set this to nil instead?
It makes logical sense considering the "credentialsProvider" argument in the previous line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a Cognito app client without a client secret,
AppClientSecretproperty in awsconfiguration.json must be completely removed. Setting it to blank""causes an(AWSMobileClient.AWSMobileClientError error 8.)(invalidParameter) error upon signing in on the app.cognitoIdentityUserPoolAppClientSecretin Constants.swift variable should be left blank.This is especially helpful considering that the default value for "Client secret" when creating an app client on the AWS console is "Don't generate a client secret".
This is in contrast to the KVS WebRTC Android SDK which can set
AppClientSecretto""in awsconfiguration.json when not using a secret.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.