Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

updates for python3 support in glue #16

Merged
merged 7 commits into from
May 5, 2021

Conversation

ryandeivert
Copy link
Contributor

@ryandeivert ryandeivert commented Sep 10, 2019

Description of changes:

AWS Glue recently launched support for python3

Including updates to convert this project to python3. The changes include the following:

  • update requirements for python3
  • converting all package code to python3
  • updating tests for python3
  • bumping version (unsure what this should actually be) and updating makefile to get version correctly

Testing:

I ensured all tests are still passing using make test

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dacort
Copy link
Contributor

dacort commented Sep 10, 2019

@ryandeivert This is awesome, thank you! Been on my backlog for a bit, so I definitely appreciate the contribution.

Will take a look at this within the next week.

@juanqui
Copy link

juanqui commented Apr 17, 2020

@ryandeivert This is awesome, thank you! Been on my backlog for a bit, so I definitely appreciate the contribution.

Will take a look at this within the next week.

Any updates on this?

@dacort
Copy link
Contributor

dacort commented Apr 17, 2020

Hi @juanqui - I unfortunately don't work at AWS anymore so not able to merge this in.

I'll try to ping somebody on my old team there, but no guarantees. Feel free to fork this, though!

@sheyd
Copy link

sheyd commented Nov 12, 2020

I did a manual zip deploy of this and ran against S3 access logs using Glue 2.0 Python3 with G.1X nodes, and it worked successfully, both for initial run, and diff updates against latest partitions. @ryandeivert Thanks for putting this PR in and @dacort for putting this code together to begin with!

@serverlesspolska
Copy link

Any news on this PR? Why it has not been merged in?

@dacort
Copy link
Contributor

dacort commented Jan 12, 2021

@serverlesspolska I was the primary maintainer of this repo, but then left Amazon and wasn't able to find a replacement. That said, I'm back at Amazon now so will take a look at what needs to be done to update this / if we should continue maintaining it. A lot has changed in the past year. :)

Makefile Show resolved Hide resolved
dacort added 2 commits May 5, 2021 10:01
Due to python3 changes, this script is incompatible with python2 now so making a major version bump.
@dacort
Copy link
Contributor

dacort commented May 5, 2021

Thanks @ryandeivert for submitting this PR and I apologize for taking checks notes almost 2 years to merge it in.

Keep an eye on the repo as there have been a lot of changes in Glue since then and Blueprints/Workflows may be the path forward.

@dacort dacort merged commit f2ffc61 into awslabs:master May 5, 2021
@ryandeivert ryandeivert deleted the ryandeivert-update-to-py3 branch September 14, 2022 21:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants