[ISSUE 21] Adding timezone support #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soojinj
requested review from
avirtuos and
atennak1
and removed request for
avirtuos
atennak1
requested changes
Mar 25, 2020
...-dynamodb/src/main/java/com/amazonaws/athena/connectors/dynamodb/util/DDBRecordMetadata.java
Show resolved
Hide resolved
...-dynamodb/src/main/java/com/amazonaws/athena/connectors/dynamodb/util/DDBRecordMetadata.java
Show resolved
Hide resolved
athena-dynamodb/src/main/java/com/amazonaws/athena/connectors/dynamodb/util/DDBTypeUtils.java
Show resolved
Hide resolved
athena-dynamodb/src/main/java/com/amazonaws/athena/connectors/dynamodb/util/DDBTypeUtils.java
Show resolved
Hide resolved
| * Class for representing timezone to be used in encoding datetime value and timezone value to a single long | ||
| * a copy from Presto TimeZoneKey | ||
| */ | ||
| public final class TimeZoneKey |
There was a problem hiding this comment.
is it possible to unpack/pack only on the Athena side? We may be leaking too much Athena-specific nuance here.
...on-sdk/src/main/java/com/amazonaws/athena/connector/lambda/handlers/GlueMetadataHandler.java
Show resolved
Hide resolved
...n-sdk/src/main/java/com/amazonaws/athena/connector/lambda/metadata/glue/DefaultGlueType.java
Show resolved
Hide resolved
avirtuos
requested changes
Mar 31, 2020
athena-federation-sdk/src/main/java/com/amazonaws/athena/connector/lambda/data/BlockUtils.java
Show resolved
Hide resolved
athena-federation-sdk/src/main/java/com/amazonaws/athena/connector/lambda/data/BlockUtils.java
Show resolved
Hide resolved
...-federation-sdk/src/main/java/com/amazonaws/athena/connector/lambda/data/SupportedTypes.java
Show resolved
Hide resolved
|
|
||
| /** | ||
| * Class for representing timezone to be used in encoding datetime value and timezone value to a single long | ||
| * a copy from Presto TimeZoneKey |
There was a problem hiding this comment.
if this is an exact copy you might need to copy attribution too. Do we really need it to be an exact copy?
Also, we need to be careful about what apache arrow type we are using for this. If a customer actually wants to use TIMESTAMPMILLI that seems to no longer be possible because we are now defining timestampmilli as something else.
...on-sdk/src/main/java/com/amazonaws/athena/connector/lambda/handlers/GlueMetadataHandler.java
Show resolved
Hide resolved
...n-sdk/src/main/java/com/amazonaws/athena/connector/lambda/metadata/glue/DefaultGlueType.java
Show resolved
Hide resolved
Comment on lines
+2
to
+9
| # DO NOT REMOVE OR MODIFY EXISTING ENTRIES | ||
| # | ||
| # This file contain the fixed numeric id of every supported time zone id. | ||
| # Every zone id in this file must be supported by java.util.TimeZone and the | ||
| # Joda time library. This is because Presto uses both java.util.TimeZone and | ||
| # the Joda time## for during execution. | ||
| # | ||
| # suppress inspection "UnusedProperty" for whole file |
There was a problem hiding this comment.
This file makes me super nervous. Can't we get this from Java runtime somehow? what happens if we country changes its offset?
|
|
||
| /** | ||
| * Class for testing timezone to be used in encoding datetime value and timezone value to a single long | ||
| * a copy from Presto TimeZoneKeyTest |
There was a problem hiding this comment.
please ensure we are putting proper attribution to presto for any code that we reuse.
abhishekpradeepmishra
pushed a commit
to abhishekpradeepmishra/aws-athena-query-federation
that referenced
this pull request
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#21
Description of changes:
SDK side of changes to support timezone