Add case insensitive schema functionality #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akuzin1
reviewed
Oct 18, 2023
athena-jdbc/src/main/java/com/amazonaws/athena/connectors/jdbc/manager/JDBCUtil.java
Outdated
Show resolved
Hide resolved
...esql/src/main/java/com/amazonaws/athena/connectors/postgresql/PostGreSqlMetadataHandler.java
Outdated
Show resolved
Hide resolved
ejeffrli
force-pushed
the
case_insensitive_schema
branch
from
6e563a0 to
9eacff2
Compare
chngpe
requested changes
Oct 19, 2023
.../src/test/java/com/amazonaws/athena/connectors/postgresql/PostGreSqlMetadataHandlerTest.java
Outdated
Show resolved
Hide resolved
athena-jdbc/src/main/java/com/amazonaws/athena/connectors/jdbc/manager/JDBCUtil.java
Outdated
Show resolved
Hide resolved
athena-jdbc/src/main/java/com/amazonaws/athena/connectors/jdbc/manager/JDBCUtil.java
Outdated
Show resolved
Hide resolved
...esql/src/main/java/com/amazonaws/athena/connectors/postgresql/PostGreSqlMetadataHandler.java
Outdated
Show resolved
Hide resolved
...esql/src/main/java/com/amazonaws/athena/connectors/postgresql/PostGreSqlMetadataHandler.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/amazonaws/athena/connectors/postgresql/PostGreSqlMetadataHandlerTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/amazonaws/athena/connectors/postgresql/PostGreSqlMetadataHandlerTest.java
Outdated
Show resolved
Hide resolved
ejeffrli
force-pushed
the
case_insensitive_schema
branch
2 times, most recently
from
0db2a27 to
67d2295
Compare
Add postgresql and mysql case insensitive functionality and mysql tests Add redshift case insesnsitive functionality and tests Set enable_case_sensitive_identifier in redshift cluster group and fix etl case insensitive job Specify customer and customer_address schema case Fix unit tests to work with case insensitive schema implementation Allow unit tests to work with case insensitive schema Refactor redshift case insensitive logic Remove debugging messages Add materialized view tests and refactor code to remove duplicate redshift and postgres code Remove duplicate check
ejeffrli
force-pushed
the
case_insensitive_schema
branch
from
7444827 to
a805e2e
Compare
chngpe
approved these changes
Oct 23, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
- Update postgreSQL version to 13.7 (#1585) - build(deps): bump net.jqwik:jqwik from 1.8.0 to 1.8.1 (#1543) - build(deps): bump hbase.version from 2.5.5-hadoop3 to 2.5.6-hadoop3 (#1544) - build(deps): bump actions/setup-node from 3 to 4 (#1552) - build(deps-dev): bump log4j2Version from 2.20.0 to 2.21.1 (#1558) - build(deps): bump org.apache.maven.plugins:maven-dependency-plugin from 3.6.0 to 3.6.1 (#1562) - build(deps): bump org.codehaus.mojo:license-maven-plugin from 2.2.0 to 2.3.0 (#1566) - build(deps): bump aws-sdk.version from 1.12.566 to 1.12.589 (#1584) - build(deps): bump org.apache.maven.plugins:maven-checkstyle-plugin from 3.3.0 to 3.3.1 (#1563) - build(deps): bump com.google.cloud:google-cloud-resourcemanager from 1.30.0 to 1.32.0 (#1579) - build(deps): bump com.mysql:mysql-connector-j from 8.1.0 to 8.2.0 (#1559) - build(deps): bump com.microsoft.azure:msal4j from 1.13.10 to 1.14.0 (#1564) - build(deps): bump com.google.cloud:google-cloud-bigquery from 2.33.2 to 2.34.2 (#1580) - build(deps): bump com.amazon.redshift:redshift-jdbc42 from 2.1.0.19 to 2.1.0.22 (#1578) - build(deps): bump com.microsoft.sqlserver:mssql-jdbc from 12.4.1.jre11 to 12.4.2.jre11 (#1554) - build(deps): bump org.jacoco:jacoco-maven-plugin from 0.8.10 to 0.8.11 (#1550) - build(deps): bump org.apache.directory.server:apacheds-kerberos-codec from 2.0.0.AM26 to 2.0.0.AM27 (#1549) - build(deps): bump commons-cli:commons-cli from 1.5.0 to 1.6.0 (#1555) - Implement elasticsearch pagination (#1581) - build(deps): bump fkirc/skip-duplicate-actions from 5.3.0 to 5.3.1 (#1541) - build(deps): bump com.google.cloud:google-cloud-storage from 2.28.0 to 2.29.1 (#1571) - Implement dynamodb pagination (#1568) - Implement MySQL, PostgreSQL, Redshift Connectors' pagination (#1567) - Add Mysql pagination implementation - Add missing check to template with KMS keys (#1572) - Add missing check to template with KMS keys - Fix checkstyle error in JDBCUtil (#1551) - Fix checksytle error in JDBCUtil - Add case insensitive schema functionality (#1539) - Add case insensitive schema functionality - Modified maven_push workflow (#1538)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MySQL, PostgreSQL, and Redshift case insensitive schema functionality and requirements for validation testing.
Issue #, if available:
Description of changes:
Allow users to query MySQL, PostgreSQL, and Redshift tables with mixed cases. Also, added tests under validation_testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.