Update aws secret pattern matcher #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akuzin1
approved these changes
Feb 14, 2024
chngpe
approved these changes
Feb 14, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
- Update aws secret pattern matcher (#1755) - build(deps): bump org.apache.directory.api:api-ldap-model from 2.1.5 to 2.1.6 (#1752) - build(deps): bump org.apache.directory.api:api-ldap-model - build(deps): bump com.google.cloud:google-cloud-resourcemanager from 1.36.0 to 1.37.0 (#1753) - build(deps): bump com.google.cloud:google-cloud-resourcemanager - build(deps): bump com.google.cloud:google-cloud-storage from 2.32.1 to 2.33.0 (#1751) - build(deps): bump com.google.cloud:google-cloud-storage - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client from 8.12.0 to 8.12.1 (#1749) - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client - build(deps): bump aws-sdk.version from 1.12.651 to 1.12.656 (#1748) - build(deps): bump aws-sdk.version from 1.12.651 to 1.12.656 - build(deps): bump slf4j-log4j.version from 2.0.11 to 2.0.12 (#1747) - build(deps): bump slf4j-log4j.version from 2.0.11 to 2.0.12 - build(deps): bump org.junit:junit-bom from 5.10.1 to 5.10.2 (#1745) - build(deps): bump org.junit:junit-bom from 5.10.1 to 5.10.2 - Revert "build(deps): bump com.google.cloud:google-cloud-bigquery" - build(deps): bump org.assertj:assertj-core from 3.25.2 to 3.25.3 (#1743) - build(deps): bump org.assertj:assertj-core from 3.25.2 to 3.25.3 - build(deps): bump aws-sdk.version from 1.12.646 to 1.12.651 (#1742) - build(deps): bump aws-sdk.version from 1.12.646 to 1.12.651 - Fix Vertica Connection Factory connection test, prevented from creating new connection after previous one closed (#1573) - build(deps): bump aws-sdk.version from 1.12.641 to 1.12.646 (#1732) - build(deps): bump aws-sdk.version from 1.12.641 to 1.12.646 - build(deps): bump org.codehaus.mojo:license-maven-plugin from 2.3.0 to 2.4.0 (#1738) - build(deps): bump org.codehaus.mojo:license-maven-plugin - build(deps): bump net.snowflake:snowflake-jdbc from 3.14.4 to 3.14.5 (#1733) - build(deps): bump net.snowflake:snowflake-jdbc from 3.14.4 to 3.14.5 - build(deps): bump com.google.cloud:google-cloud-bigquery from 2.36.0 to 2.37.0 (#1734) - build(deps): bump com.google.cloud:google-cloud-bigquery - build(deps): bump org.assertj:assertj-core from 3.25.1 to 3.25.2 (#1737) - build(deps): bump org.assertj:assertj-core from 3.25.1 to 3.25.2 - build(deps): bump com.google.cloud:google-cloud-storage from 2.31.0 to 2.32.1 (#1736) - build(deps): bump com.google.cloud:google-cloud-storage - build(deps): bump com.mysql:mysql-connector-j from 8.2.0 to 8.3.0 (#1724) - build(deps): bump com.mysql:mysql-connector-j from 8.2.0 to 8.3.0 - build(deps): bump com.google.cloud:google-cloud-resourcemanager from 1.35.0 to 1.36.0 (#1731) - build(deps): bump com.google.cloud:google-cloud-resourcemanager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1381
Currently, the regex used to find aws secrets in the connection string does not allow for all of the special characters that aws secrets manager allows (see AWS Secrets Documentation). This adds the all of the supported characters to the regex used.