JDBC QPT Implementation; with MySQL Connector #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdulR3hman
commented
Feb 23, 2024
| @@ -48,12 +48,16 @@ public static ArrowType toArrowType(final int jdbcType, final int precision, fin | |||
| int defaultScale = Integer.parseInt(configOptions.getOrDefault("default_scale", "0")); | |||
| int resolvedPrecision = precision; | |||
| int resolvedScale = scale; | |||
| boolean needsResolving = jdbcType == Types.NUMERIC && (precision == 0 && scale == 0); | |||
| boolean needsResolving = jdbcType == Types.NUMERIC && (precision == 0 && scale <= 0); | |||
There was a problem hiding this comment.
these are precision issues we've found in testing.
akuzin1
approved these changes
Feb 23, 2024
|
Code is cherry picked from the querypassthrough-sdk and has been baking and testing |
AbdulR3hman
force-pushed
the
qpt-jdbc
branch
from
9317ccd to
f47e0a7
Compare
akuzin1
approved these changes
Feb 23, 2024
AbdulR3hman
force-pushed
the
qpt-jdbc
branch
from
f47e0a7 to
b30a149
Compare
chngpe
approved these changes
Feb 26, 2024
AbdulR3hman
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
- JDBC QPT Implementation; with MySQL Connector (#1774) - Deploy Mysql and JDBC Connectors to Maven Central (#1775) - Maven dependency revert (#1791) - Disabled Automerge DependBot PRs Temporarily (#1789) - build(deps): bump org.apache.maven.plugins:maven-shade-plugin from 3.5.1 to 3.5.2 (#1785) - build(deps): bump org.apache.maven.plugins:maven-shade-plugin - build(deps): bump slf4j-log4j.version from 2.0.7 to 2.0.12 (#1779) - build(deps): bump slf4j-log4j.version from 2.0.7 to 2.0.12 - build(deps): bump com.microsoft.azure:msal4j from 1.14.2 to 1.14.3 (#1780) - build(deps): bump com.microsoft.azure:msal4j from 1.14.2 to 1.14.3 - build(deps-dev): bump log4j2Version from 2.22.1 to 2.23.0 (#1782) - build(deps-dev): bump log4j2Version from 2.22.1 to 2.23.0 - build(deps): bump com.microsoft.sqlserver:mssql-jdbc from 12.4.2.jre11 to 12.6.1.jre11 (#1778) - build(deps): bump com.microsoft.sqlserver:mssql-jdbc - build(deps): bump net.jqwik:jqwik from 1.8.2 to 1.8.3 (#1784) - build(deps): bump net.jqwik:jqwik from 1.8.2 to 1.8.3 - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client from 8.12.1 to 8.12.2 (#1787) - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client - build(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 3.15.6 to 3.15.7 (#1786) - build(deps-dev): bump nl.jqno.equalsverifier:equalsverifier - build(deps): bump com.google.cloud:google-cloud-resourcemanager from 1.37.0 to 1.38.0 (#1781) - build(deps): bump com.google.cloud:google-cloud-resourcemanager - build(deps): bump net.snowflake:snowflake-jdbc from 3.14.5 to 3.15.0 (#1783) - build(deps): bump net.snowflake:snowflake-jdbc from 3.14.5 to 3.15.0 - build(deps): bump fasterxml.jackson.version from 2.12.6 to 2.16.1 (#1777) - build(deps): bump fasterxml.jackson.version from 2.12.6 to 2.16.1 - build(deps): bump aws-sdk.version from 1.12.533 to 1.12.666 (#1776) - build(deps): bump aws-sdk.version from 1.12.533 to 1.12.666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will provide the heavy lifting required for the jdbc-based connectors to implement QPT; moreover adding MySQL as one of the first connectors to extend QPT functionality.