Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake split issue #1963

Merged
merged 6 commits into from
May 17, 2024
Merged

Snowflake split issue #1963

merged 6 commits into from
May 17, 2024

Conversation

ejeffrli
Copy link
Contributor

@ejeffrli ejeffrli commented May 9, 2024

Issue #, if available:

Description of changes:
Fixes the issue of getting incorrect aggregation results when using limit/offset without order by. Implement partitions to work with primary key if customer has one defined.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ejeffrli ejeffrli force-pushed the snowflake_split_issue branch from eaca2a6 to 303e4b6 Compare May 13, 2024 16:43
Copy link
Contributor

@chngpe chngpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix minor comment

@ejeffrli ejeffrli enabled auto-merge (squash) May 17, 2024 19:36
@ejeffrli ejeffrli merged commit 71d3320 into master May 17, 2024
7 of 8 checks passed
@ejeffrli ejeffrli deleted the snowflake_split_issue branch May 17, 2024 19:51
github-actions bot pushed a commit that referenced this pull request May 17, 2024
  - Snowflake split issue (#1963)
  - Com.google.cloud google cloud bigquery version update (#1975)
  - Fix ValidationException for Timestream connector (#1888)
  - build(deps): bump com.amazon.redshift:redshift-jdbc42 from 2.1.0.27 to 2.1.0.28 in /athena-redshift (#1974)
  - build(deps): bump com.amazon.redshift:redshift-jdbc42
  - Updated prepare_dev_env.sh script (#1972)
  - Revert "build(deps): bump com.google.cloud:google-cloud-bigquery" (#1971)
  - build(deps): bump com.google.cloud:google-cloud-bigquery from 2.37.0 to 2.40.1 (#1962)
  - build(deps): bump com.google.cloud:google-cloud-bigquery
  - build(deps): bump com.google.api.grpc:grpc-google-cloud-bigquerystorage-v1 from 2.47.0 to 3.5.1 (#1961)
  - build(deps): bump com.google.api.grpc:grpc-google-cloud-bigquerystorage-v1
  - build(deps): bump gremlinDriverVersion from 3.6.5 to 3.7.2 (#1967)
  - build(deps): bump gremlinDriverVersion from 3.6.5 to 3.7.2
  - build(deps): bump com.google.cloud:google-cloud-resourcemanager from 1.44.0 to 1.45.0 (#1968)
  - build(deps): bump com.google.cloud:google-cloud-resourcemanager
  - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client from 8.13.3 to 8.13.4 (#1970)
  - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client
  - build(deps): bump com.amazon.redshift:redshift-jdbc42 from 2.1.0.26 to 2.1.0.27 (#1969)
  - build(deps): bump com.amazon.redshift:redshift-jdbc42
  - build(deps): bump software.amazon.awssdk:bom from 2.25.45 to 2.25.50 (#1965)
  - build(deps): bump software.amazon.awssdk:bom from 2.25.45 to 2.25.50
  - build(deps): bump com.google.cloud:google-cloud-storage from 2.37.0 to 2.38.0 (#1966)
  - build(deps): bump com.google.cloud:google-cloud-storage
  - build(deps): bump aws-sdk.version from 1.12.715 to 1.12.720 (#1964)
  - build(deps): bump aws-sdk.version from 1.12.715 to 1.12.720
  - Enable map of complex types support (#1917)
  - unifying vertica connector as jdbc connector (#1918)
  - Feature/oracle fips (#1946)
  - Updated SigV4 signing library in Gremlin connection for Neptune connector (#1698)
github-actions bot pushed a commit that referenced this pull request May 20, 2024
  - build(deps): bump io.grpc:grpc-api from 1.63.0 to 1.64.0 (#1980)
  - build(deps): bump io.grpc:grpc-api from 1.63.0 to 1.64.0
  - build(deps): bump hbase.version from 2.5.8-hadoop3 to 2.6.0-hadoop3 (#1977)
  - build(deps): bump hbase.version from 2.5.8-hadoop3 to 2.6.0-hadoop3
  - build(deps): bump software.amazon.awssdk:bom from 2.25.50 to 2.25.55 (#1978)
  - build(deps): bump software.amazon.awssdk:bom from 2.25.50 to 2.25.55
  - build(deps): bump aws-sdk.version from 1.12.720 to 1.12.725 (#1976)
  - build(deps): bump aws-sdk.version from 1.12.720 to 1.12.725
  - Snowflake split issue (#1963)
  - Com.google.cloud google cloud bigquery version update (#1975)
  - Fix ValidationException for Timestream connector (#1888)
  - build(deps): bump com.amazon.redshift:redshift-jdbc42 from 2.1.0.27 to 2.1.0.28 in /athena-redshift (#1974)
  - build(deps): bump com.amazon.redshift:redshift-jdbc42
  - Updated prepare_dev_env.sh script (#1972)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants