-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snowflake split issue #1963
Merged
Merged
Snowflake split issue #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdulR3hman
reviewed
May 10, 2024
...wflake/src/main/java/com/amazonaws/athena/connectors/snowflake/SnowflakeMetadataHandler.java
Outdated
Show resolved
Hide resolved
AbdulR3hman
reviewed
May 10, 2024
...wflake/src/main/java/com/amazonaws/athena/connectors/snowflake/SnowflakeMetadataHandler.java
Outdated
Show resolved
Hide resolved
AbdulR3hman
reviewed
May 10, 2024
...wflake/src/main/java/com/amazonaws/athena/connectors/snowflake/SnowflakeMetadataHandler.java
Outdated
Show resolved
Hide resolved
eaca2a6
to
303e4b6
Compare
chngpe
approved these changes
May 14, 2024
...wflake/src/main/java/com/amazonaws/athena/connectors/snowflake/SnowflakeMetadataHandler.java
Outdated
Show resolved
Hide resolved
...wflake/src/main/java/com/amazonaws/athena/connectors/snowflake/SnowflakeMetadataHandler.java
Show resolved
Hide resolved
chngpe
requested changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix minor comment
chngpe
approved these changes
May 17, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 17, 2024
- Snowflake split issue (#1963) - Com.google.cloud google cloud bigquery version update (#1975) - Fix ValidationException for Timestream connector (#1888) - build(deps): bump com.amazon.redshift:redshift-jdbc42 from 2.1.0.27 to 2.1.0.28 in /athena-redshift (#1974) - build(deps): bump com.amazon.redshift:redshift-jdbc42 - Updated prepare_dev_env.sh script (#1972) - Revert "build(deps): bump com.google.cloud:google-cloud-bigquery" (#1971) - build(deps): bump com.google.cloud:google-cloud-bigquery from 2.37.0 to 2.40.1 (#1962) - build(deps): bump com.google.cloud:google-cloud-bigquery - build(deps): bump com.google.api.grpc:grpc-google-cloud-bigquerystorage-v1 from 2.47.0 to 3.5.1 (#1961) - build(deps): bump com.google.api.grpc:grpc-google-cloud-bigquerystorage-v1 - build(deps): bump gremlinDriverVersion from 3.6.5 to 3.7.2 (#1967) - build(deps): bump gremlinDriverVersion from 3.6.5 to 3.7.2 - build(deps): bump com.google.cloud:google-cloud-resourcemanager from 1.44.0 to 1.45.0 (#1968) - build(deps): bump com.google.cloud:google-cloud-resourcemanager - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client from 8.13.3 to 8.13.4 (#1970) - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client - build(deps): bump com.amazon.redshift:redshift-jdbc42 from 2.1.0.26 to 2.1.0.27 (#1969) - build(deps): bump com.amazon.redshift:redshift-jdbc42 - build(deps): bump software.amazon.awssdk:bom from 2.25.45 to 2.25.50 (#1965) - build(deps): bump software.amazon.awssdk:bom from 2.25.45 to 2.25.50 - build(deps): bump com.google.cloud:google-cloud-storage from 2.37.0 to 2.38.0 (#1966) - build(deps): bump com.google.cloud:google-cloud-storage - build(deps): bump aws-sdk.version from 1.12.715 to 1.12.720 (#1964) - build(deps): bump aws-sdk.version from 1.12.715 to 1.12.720 - Enable map of complex types support (#1917) - unifying vertica connector as jdbc connector (#1918) - Feature/oracle fips (#1946) - Updated SigV4 signing library in Gremlin connection for Neptune connector (#1698)
github-actions bot
pushed a commit
that referenced
this pull request
May 20, 2024
- build(deps): bump io.grpc:grpc-api from 1.63.0 to 1.64.0 (#1980) - build(deps): bump io.grpc:grpc-api from 1.63.0 to 1.64.0 - build(deps): bump hbase.version from 2.5.8-hadoop3 to 2.6.0-hadoop3 (#1977) - build(deps): bump hbase.version from 2.5.8-hadoop3 to 2.6.0-hadoop3 - build(deps): bump software.amazon.awssdk:bom from 2.25.50 to 2.25.55 (#1978) - build(deps): bump software.amazon.awssdk:bom from 2.25.50 to 2.25.55 - build(deps): bump aws-sdk.version from 1.12.720 to 1.12.725 (#1976) - build(deps): bump aws-sdk.version from 1.12.720 to 1.12.725 - Snowflake split issue (#1963) - Com.google.cloud google cloud bigquery version update (#1975) - Fix ValidationException for Timestream connector (#1888) - build(deps): bump com.amazon.redshift:redshift-jdbc42 from 2.1.0.27 to 2.1.0.28 in /athena-redshift (#1974) - build(deps): bump com.amazon.redshift:redshift-jdbc42 - Updated prepare_dev_env.sh script (#1972)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fixes the issue of getting incorrect aggregation results when using limit/offset without order by. Implement partitions to work with primary key if customer has one defined.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.