Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hard coded AWS Partition #2544

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Fix hard coded AWS Partition #2544

merged 1 commit into from
Jan 22, 2025

Conversation

AbdulR3hman
Copy link
Contributor

Issue #, if available:
AWS Partition was hard-coded for many of the resources in the cloudformation. I have made the changes to ensure that we programmatically substitute the correct partition.

I have tested this by both deploying to commercial and non-commercial regions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.21%. Comparing base (c83e8f2) to head (0cb37e0).
Report is 43 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2544      +/-   ##
============================================
- Coverage     61.21%   61.21%   -0.01%     
+ Complexity     3756     3754       -2     
============================================
  Files           577      577              
  Lines         21435    21435              
  Branches       2659     2659              
============================================
- Hits          13122    13121       -1     
  Misses         7042     7042              
- Partials       1271     1272       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AbdulR3hman AbdulR3hman merged commit cd2fa85 into master Jan 22, 2025
10 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 22, 2025
  - Fix hard coded AWS Partition (#2544)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants