Upgrade Athena engine version to v3 #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
It seems that Athena has deprecated engine version 2 in some regions but not all. When running the command Regions that CANNOT use Athena engine v2:
I tested this PR in eu-central-1 and it solves the issue. Also tested upgrade from engine 2 to 3 and the environment stack updates successfully |
dlpzx
added
type: bug
noah-paige
added a commit
that referenced
this pull request
Nov 28, 2023
### Feature or Bugfix <!-- please choose --> - Bugfix ### Detail - When trying to update an Environment to use the latest Athena Version (from this [previous PR](#886)) and having CDK use the data.all provided CDK Execution Policy ran into an `Update_Failed` error on the Environment CloudFormation Stack due to missing permissions for `athena:UpdateWorkGroup` - Added `athena:UpdateWorkGroup` to the CDK Exec Policy YAML file ### Relates - N/A ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
It is not a bug yet but Athena has already included he following warning at workgroup creation
Athena engine version 2 will be deprecated in the near future. You can view this information in your AWS Personal Health Dashboard. Workgroups not upgraded by the deprecation date will be upgraded to version 3 automatically.To avoid future failures, we are updating the engine version selected for the creation to new workgroups in data.all to version 3.
Here is the documentation of version 3 which include the breaking changes from v2. Engine version 3 was released on October 13, 2022 and as it can be verified in the Athena release notes, it has been constantly improved during this year, surpassing in features athena v2.
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
N/Afetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.