Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Athena:UpdateWorkGroup permissions to CDK Exec Policy #892

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

noah-paige
Copy link
Contributor

@noah-paige noah-paige commented Nov 27, 2023

Feature or Bugfix

  • Bugfix

Detail

  • When trying to update an Environment to use the latest Athena Version (from this previous PR) and having CDK use the data.all provided CDK Execution Policy ran into an Update_Failed error on the Environment CloudFormation Stack due to missing permissions for athena:UpdateWorkGroup
    • Added athena:UpdateWorkGroup to the CDK Exec Policy YAML file

Relates

  • N/A

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@noah-paige
Copy link
Contributor Author

Tested in AWS - updating an environment's CFN Stack after using the newer CDKExecPolicy.yaml and successfully updated stack + confirmed Athena Workgroup version updated

@noah-paige noah-paige marked this pull request as ready for review November 27, 2023 21:12
Copy link
Contributor

@dlpzx dlpzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the fix

@noah-paige noah-paige merged commit 6f6a69c into main Nov 28, 2023
9 checks passed
@dlpzx dlpzx deleted the add-cdk-exec-permissions-athena-workgroup branch January 10, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants